Skip to content

fix(webgpu): reading a mapped buffer throws on a detached ArrayBuffer #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fslabs-bot merged 1 commit into from
Aug 5, 2026
Merged

fix(webgpu): reading a mapped buffer throws on a detached ArrayBuffer #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions wgpu/src/backend/webgpu.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1215,8 +1215,9 @@ struct WebBufferMapState {
pub struct WebBuffer {
/// The associated GPU buffer.
inner: webgpu_sys::GpuBuffer,
/// The mapped array buffer and mapped range.
mapping: RefCell<WebBufferMapState>,
/// The mapped array buffer and mapped range. Shared across clones, because an unmap through
/// any one clone detaches the `ArrayBuffer` for all of them.
mapping: Rc<RefCell<WebBufferMapState>>,
/// Unique identifier for this Buffer.
ident: crate::cmp::Identifier,
}
Expand All @@ -1226,10 +1227,10 @@ impl WebBuffer {
fn new(inner: webgpu_sys::GpuBuffer, desc: &crate::BufferDescriptor<'_>) -> Self {
Self {
inner,
mapping: RefCell::new(WebBufferMapState {
mapping: Rc::new(RefCell::new(WebBufferMapState {
mapped_buffer: None,
range: 0..desc.size,
}),
})),
ident: crate::cmp::Identifier::create(),
}
}
Expand Down
Loading