plugin: add Android dev skills#89
Conversation
|
Warning Review limit reached
More reviews will be available in 53 minutes and 41 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
📝 WalkthroughWalkthroughThe ChangesAndroid Dev Skills Plugin Implementation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 854c56ad4a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| owner: gaelic-ghost | ||
| repo: socket | ||
| category: android-planning | ||
| allowed-tools: Read Bash(rg:*) Bash(git:*) Bash(java:*) Bash(./gradlew:*) Bash(gradle:*) Bash(adb:*) Bash(aapt:*) Bash(aapt2:*) |
There was a problem hiding this comment.
When this planning/routing skill is selected, it grants unrestricted adb even though the new Android guidance says emulator/device validation should be handed off instead of run from these skills. The official Android adb docs describe adb as a device-communication tool that can install/debug apps and provide a Unix shell, so Bash(adb:*) lets an ordinary project-shape request directly inspect or mutate a connected device instead of routing to the owned testing surface; please remove adb from these guidance skills or narrow it to a read-only status command. See: https://developer.android.com/tools/adb
Useful? React with 👍 / 👎.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 6
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@plugins/android-dev-skills/skills/build-kotlin-android/SKILL.md`:
- Around line 1-10: The SKILL.md frontmatter for build-kotlin-android is missing
the required compatibility metadata field, so update the YAML header to include
it alongside name, description, license, and metadata. Keep the existing
structure intact and make sure the new field matches the repo’s expected format
used by validate_repo_metadata.py so this skill passes validation like the other
skill definitions.
In `@plugins/android-dev-skills/skills/choose-project-shape/SKILL.md`:
- Around line 1-10: The SKILL.md frontmatter for choose-project-shape is missing
the required compatibility field, which will break metadata validation. Update
the frontmatter in this skill file to include compatibility alongside name,
description, license, metadata, and allowed-tools, matching the
REQUIRED_FRONTMATTER_FIELDS contract used by validate_repo_metadata.py.
In `@plugins/android-dev-skills/skills/gradle-agp-workflow/SKILL.md`:
- Around line 1-10: The SKILL.md frontmatter for gradle-agp-workflow is missing
the required compatibility field, which causes metadata validation to fail.
Update the YAML header to include compatibility alongside the existing name,
description, license, and metadata fields, and make sure the value matches the
repository’s expected Android build support constraints. Use the existing
frontmatter block in SKILL.md as the place to add it.
In `@plugins/android-dev-skills/skills/java-android-workflow/SKILL.md`:
- Around line 1-10: The SKILL.md frontmatter for java-android-workflow is
missing the required compatibility field, which must be added to satisfy
validate_repo_metadata.py. Update the frontmatter in the java-android-workflow
skill metadata alongside name, description, license, and metadata, and include a
compatibility value that matches the skill’s Android/Java support scope.
In `@plugins/android-dev-skills/skills/testing-lint-workflow/SKILL.md`:
- Around line 1-10: The SKILL.md frontmatter is missing the required
compatibility metadata field, so add it alongside the existing
name/description/license/metadata block to satisfy validate_repo_metadata.py.
Update the frontmatter in testing-lint-workflow to include compatibility with
the appropriate value for this skill, keeping the rest of the metadata
unchanged.
In `@ROADMAP.md`:
- Line 424: The completed validation claim in ROADMAP.md is inconsistent with
the current validator contract because the referenced
`validate_socket_metadata.py` would flag missing `compatibility` frontmatter in
the provided `SKILL.md` files. Update the ROADMAP entry to reflect the actual
validation outcome, or add the missing `compatibility` field in the affected
SKILL metadata and rerun the validation so the claim matches the checked state.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: cc40cdd9-5dc3-4842-85bd-393a37eb4e73
📒 Files selected for processing (14)
.agents/plugins/marketplace.jsonCONTRIBUTING.mdREADME.mdROADMAP.mdTODO.mddocs/maintainers/android-dev-skills-plugin-plan.mdplugins/android-dev-skills/.codex-plugin/plugin.jsonplugins/android-dev-skills/AGENTS.mdplugins/android-dev-skills/skills/build-kotlin-android/SKILL.mdplugins/android-dev-skills/skills/choose-project-shape/SKILL.mdplugins/android-dev-skills/skills/gradle-agp-workflow/SKILL.mdplugins/android-dev-skills/skills/java-android-workflow/SKILL.mdplugins/android-dev-skills/skills/release-readiness-workflow/SKILL.mdplugins/android-dev-skills/skills/testing-lint-workflow/SKILL.md
| - [x] Add `android-dev:release-readiness-workflow` for versioning, signing, release builds, R8/ProGuard, app bundles, APKs, Play delivery handoffs, permissions, privacy checks, and release automation routing. | ||
| - [x] Update plugin metadata after real skills land, including `skills`, keywords, prompts, and accurate installable descriptions. | ||
| - [x] Switch the root marketplace entry to installable only after real skill content exists. | ||
| - [x] Run root metadata validation with `uv run scripts/validate_socket_metadata.py`. |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
Validation claim discrepancy: validate_socket_metadata.py would fail on missing compatibility fields.
The ROADMAP claims "Run root metadata validation with uv run scripts/validate_socket_metadata.py" as completed, but all five provided SKILL.md files are missing the required compatibility frontmatter field. Per the validator contract (REQUIRED_FRONTMATTER_FIELDS), this should produce findings. Either the validation script run was a different version, the field was removed after validation, or the validation claim needs correction.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@ROADMAP.md` at line 424, The completed validation claim in ROADMAP.md is
inconsistent with the current validator contract because the referenced
`validate_socket_metadata.py` would flag missing `compatibility` frontmatter in
the provided `SKILL.md` files. Update the ROADMAP entry to reflect the actual
validation outcome, or add the missing `compatibility` field in the affected
SKILL metadata and rerun the validation so the claim matches the checked state.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Addressed the compatibility metadata review comments in 37ca90d by adding |
1 participant
Summary
Verification
Summary by CodeRabbit
New Features
Documentation