Potential vulnerability patches#88
Open
dankmeme01 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you can't beat them, join them.. so this is an AI powered PR to fix potential security holes & DoS vectors in the index :D
(note: AI only used to find, not fix)
changes:
image::load_from_memoryreplaced with a safer version that respects limitsper_pagevalues) are now clampedLocalStoragechanged to not allow path traversal (future proofing, impossible in current code)takeand not read more bytes than advertised in the file metadata. I don't know if this is a true vulnerability, but after a quick read ofzip's source code, I could not find it clearly enforcing the limit, so this validation might not be pointlessnon-security changes:
GithubClientstruct created on demand each time? Why was areqwest::Clientcreated on demand on every operation in that client? We may never know.