Extend swarm lens set to 11 lenses in 4 clusters#35
Open
gering wants to merge 1 commit into
Open
Conversation
- Add methodological lenses (removed-behavior, cross-file-trace) and design-quality lenses (reuse, simplification, efficiency, altitude), all default-on and gate-pruned per-lens like any lens - Add LENS_CLUSTERS (breakage/threat/design/consistency) as single source of truth; Claude fan-out runs one finder per cluster by default (<=4 agents), one per lens under --max (<=11) - Derive kind (defect|design) from the lens name — no finding-schema change; mixed merge clusters stay defects - Verify design solos with a kind-aware applicability prompt through the same 3-state verifier (decision: verify, not bypass) - Render design findings in their own report table with shared numbering; balance.design counts the subset - Extend the external backend prompt with the six new angles so cross-family consensus can form on design findings too - Fix the lens-prefix regex to accept hyphenated lens names - Sweep docs/knowledge; bump swarm 0.4.2 -> 0.5.0 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0126cGxsBYxqgEFH4AcpriNk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/swarm:review's Claude lens set from 5 topical lenses to 11 by importing the two missing decomposition axes: methodological (removed-behavior,cross-file-trace) and design quality (reuse,simplification,efficiency,altitude) — all default-on, so every run reviews maintainability, not just defects.LENS_CLUSTERS— single source of truth for the follow-up per-cluster externals task): breakage / threat / design / consistency. The Claude fan-out runs one finder per cluster by default (≤4 agents);--maxsplits to one finder per lens (≤11). The gate still prunes per-lens; an empty cluster spawns no agent.kind: "design"(no finding-schema change), pass the same 3-state verifier with a kind-aware applicability prompt (reuse target real? simpler form behavior-identical?), and render in their ownDesignreport table so suggestions never dilute the defect ranking.Changes
plugins/swarm/workflows/swarm-review.js— 6 new lens briefs;LENS_CLUSTERS+lensKind; per-cluster/per-lens fan-out ladder; gate prompt treats design lenses first-class; lens-prefix regex accepts hyphenated names ([\w-]); member-derived cluster kind (mixed ⇒ defect); kind-aware verify prompt; kind-first ranking;balance.designplugins/swarm/skills/review/SKILL.md— external prompt names all 11 angles (one broad prompt per backend, as before); report renders a second same-formatDesigntable with shared numbering; balance line gains· <design> Design;--prpost tags design rows with their lens;--max+ Notes docsswarm-review-pipeline.md(lens table + verify-path decision), root README, CLAUDE.md, CHANGELOGReadiness
maincheck-structure.py: 0 errors (3 pre-existing description-length warnings)Test plan
/swarm:reviewon a mixed diff: 4 cluster finders spawn (watch/workflows), findings keep per-lens[lens]prefixes/swarm:review --max: one finder per gated lens (≤11), design lenses atxhighDesigntable after with shared numbering; balance shows· <n> Designefficiency-style lenses with a one-clause why🤖 Generated with Claude Code
https://claude.ai/code/session_0126cGxsBYxqgEFH4AcpriNk