docs: handoff brief for the remaining payment-audit work - #72
Open
keithfawcett wants to merge 2 commits into
Open
docs: handoff brief for the remaining payment-audit work#72keithfawcett wants to merge 2 commits into
keithfawcett wants to merge 2 commits into
Conversation
Self-contained brief for a fresh agent to pick up the three deferred items: the direct-Connect transfer double-pay (durable-intent restructure, with the funding executor as the reference and the deterministic-key shortcut warning), the rest of the funding-pipeline races, and export portability. Includes the ground truth (prod facts, manual-payout context, commands, branch conventions) and the 12 shipped audit PRs + post-merge actions. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Turns the handoff brief into a status record: what each item was, what actually shipped, and — the part that is still open — the staging exercises that have to pass before either money path is trusted. Item A (#10, PR #73): planner/executor split with a durable payout intent and a frozen commission set. Item B (#12, PR #75): the three funding races plus a live-Stripe backstop for missed refund/reversal webhooks. Item C (#8, PR #74): the three missing tables, per-table primary keys, a portable SQL dump, and two array round-trip bugs the test found. No code left on any of the three; the remaining work is the staging checklists in docs/direct-connect-payouts.md and section H of the funding staging runbook, plus the two post-merge prod actions for #62 and #63. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A self-contained handoff (
docs/audit-remaining-work.md) so a fresh agent can pick up the three deferred items from the payment/subscription audit without re-deriving context:funding/executor.tscited as the reference implementation and an explicit warning about why the deterministic-key shortcut double-pays on commission-set change.PartnerCommissionPK gotcha, import order, and the SQL-dump requirement.Plus the ground truth a new agent needs: prod facts (app-role/RLS live, manual payout rail, funding flag off), commands, branch conventions, the 12 shipped audit PRs, and the two post-merge actions (#62 migrate, #63 job-run + backlog check).
Everything the audit surfaced beyond these three has shipped as PRs #60–#71 (all reviewed; the second batch's Codex findings were fixed on their branches).
🤖 Generated with Claude Code