Skip to content

ref(transactions): Small code cleanup#6206

Open
Dav1dde wants to merge 1 commit into
masterfrom
dav1d/ref-tx-cleanup
Open

ref(transactions): Small code cleanup#6206
Dav1dde wants to merge 1 commit into
masterfrom
dav1d/ref-tx-cleanup

Conversation

@Dav1dde

@Dav1dde Dav1dde commented Jul 10, 2026

Copy link
Copy Markdown
Member
  • Metrics was never initialized with a value
  • The fully normalized is a bug, from what I remember this was there for when we introduced this fully normalized flag in the first place, let's just debug assert it
  • Flipped the if ctx.is_processing() condition to get a slightly easier control flow with less indentation

@Dav1dde Dav1dde requested a review from a team as a code owner July 10, 2026 09:16
@Dav1dde Dav1dde self-assigned this Jul 10, 2026
Comment thread relay-server/src/processing/transactions/process.rs
@Dav1dde Dav1dde force-pushed the dav1d/ref-tx-cleanup branch from 1c3d3b1 to 8abd2cf Compare July 10, 2026 09:26
@Dav1dde Dav1dde force-pushed the dav1d/ref-tx-cleanup branch from 8abd2cf to 1db9710 Compare July 10, 2026 09:41
@Dav1dde Dav1dde enabled auto-merge July 10, 2026 09:41
@Dav1dde Dav1dde added this pull request to the merge queue Jul 10, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants