docs(dotnet): clarify SQLClient instrumentation is unavailable on .NET Framework#18559
Merged
Conversation
…T Framework SqlClient's DiagnosticSource events aren't emitted on .NET Framework, so the SQLClient instrumentation in the Sentry.DiagnosticSource package has no effect there. On non-.NET Core targets that package only provides Entity Framework Core instrumentation. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
jamescrosswell
commented
Jun 26, 2026
Flash0ver
approved these changes
Jul 8, 2026
Member
There was a problem hiding this comment.
This does not need to wait for the release of Sentry .NET SDK v6.7.0. #5236 just eliminates code for the net462 TFM without SqlClient-instrumentation.
Got an optional question and suggestion ... but also good to go ✅.
Thanks!
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…o dotnet-sqlclient-netfx-docs # Conflicts: # platform-includes/performance/automatic-instrumentation-integrations/dotnet.mdx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Clarifies that the
Sentry.DiagnosticSourcepackage only provides Entity Framework Core instrumentation on non-.NET Core targets (e.g. .NET Framework). SqlClient'sDiagnosticSourceevents aren't emitted on .NET Framework, so the SQLClient instrumentation silently has no effect there.This aligns the docs with getsentry/sentry-dotnet#5236, which excludes the non-functional SQLClient listener from .NET Framework builds.
Sentry.DiagnosticSource(not "those instrumentations"), and pointed to the SQLClient note below. Also fixed a small grammar typo ("during on the SDK's initialization").IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
🤖 Generated with Claude Code