ref(core): Move spanStreamingIntegration setup into ServerRuntimeClient#21814
Open
Lms24 wants to merge 1 commit into
Open
ref(core): Move spanStreamingIntegration setup into ServerRuntimeClient#21814Lms24 wants to merge 1 commit into
spanStreamingIntegration setup into ServerRuntimeClient#21814Lms24 wants to merge 1 commit into
Conversation
Contributor
size-limit report 📦
|
Lms24
requested review from
JPeer264,
andreiborza,
mydea and
timfish
and removed request for
a team
timfish
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that all our server runtime SDKs support span streaming (they didn't initially), we can move the per-SDK-init-based logic to add
spanStreamingIntegrationiftraceLifecycle: 'stream'was set, to theServerRuntimeClient.This makes span streaming enabling more consistent for setups that only use a client. Also for SDKs like electron that init themselves with e.g. a
NodeClientand therefore hat to manually add the integration. h/t @timfish for raising this