Skip to content

chore: Deprecate the enable_logs option - #1299

Open
szokeasaurusrex wants to merge 1 commit into
masterfrom
szokeasaurusrex/enable-logs-deprecation
Open

chore: Deprecate the enable_logs option#1299
szokeasaurusrex wants to merge 1 commit into
masterfrom
szokeasaurusrex/enable-logs-deprecation

Conversation

@szokeasaurusrex

@szokeasaurusrex szokeasaurusrex commented Aug 13, 2026

Copy link
Copy Markdown
Member

Providing the ability to disable sending logs is somewhat of a footgun, as this flag can prevent all Sentry logs from being sent, so this change turns that option into a no-op, ensuring logs are always enabled.

Logs are only sent when users explicitly record them with the logging APIs we provide or when one of the integrations that captures logs (currently tracing, log, or slog) are enabled. Users who do not want logs can either stop using the logging APIs, disable the integrations which capture logs, or adjust said integrations' configurations.

Resolves #1297
Resolves RUST-274

@szokeasaurusrex
szokeasaurusrex marked this pull request as ready for review August 13, 2026 11:21
@szokeasaurusrex
szokeasaurusrex requested a review from a team as a code owner August 13, 2026 11:21
@linear-code

linear-code Bot commented Aug 13, 2026

Copy link
Copy Markdown

RUST-274

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit c98feda. Configure here.

Comment thread sentry-core/src/client/mod.rs Outdated
Comment thread sentry-core/src/client/mod.rs
Comment thread sentry-core/src/clientoptions.rs
Comment thread sentry-core/src/client/mod.rs
Comment thread sentry-core/src/clientoptions.rs
Providing the ability to disable sending logs is somewhat of a footgun, as this flag can prevent all Sentry logs from being sent, so this change turns that option into a no-op, ensuring logs are always enabled.

Logs are only sent when users explicitly record them with the logging APIs we provide or when one of the integrations that captures logs (currently `tracing`, `log`, or `slog`) are enabled. Users who do not want logs can either stop using the logging APIs, disable the integrations which capture logs, or adjust said integrations' configurations.

Resolves [#1297](#1297)
Resolves [RUST-274](https://linear.app/getsentry/issue/RUST-274/deprecate-and-no-op-ify-enable-logs)
@szokeasaurusrex
szokeasaurusrex force-pushed the szokeasaurusrex/enable-logs-deprecation branch from 1d9ba55 to fd719e1 Compare August 13, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecate and no-op-ify enable_logs

2 participants