Fix TileDynamoMJ tech debt: cache biome + safe overheat shutdown - #1
Open
ghshhf wants to merge 1 commit into
Open
Fix TileDynamoMJ tech debt: cache biome + safe overheat shutdown#1ghshhf wants to merge 1 commit into
ghshhf wants to merge 1 commit into
Conversation
…eat shutdown) - Cache the biome lookup in getBiome() instead of querying world every call (was flagged TODO: Cache this!). Tile position is fixed so the result never changes; cache is invalidated in readFromNBT. - Replace the disabled destructive overheat behaviour (engine explosion / block removal) with a safe shutdown: when overheated the engine stops accepting further RF input. It keeps cooling in update() and auto-resumes once heat drops below the overheat threshold. Matches the existing "don't burn while overheated" guard. - Remove two stale "TODO: sync gui data" comments: heat/currentOutput are already synced via NET_GUI_DATA in writePayload/readPayload.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses three
TileDynamoMJtech-debt items from the known-tech-debt list:getBiome()): previously calledworld.getBiome(getPos())on every invocation. The tile position is fixed so the biome never changes — now cached in a field and invalidated inreadFromNBT.addPower): the old// TODO: turn engine offwas commented-out destructive code (engine explosion / block removal). Replaced with a non-destructive shutdown — whenOVERHEAT, the engine stops accepting further RF input and just keeps cooling (already the behaviour guarded inupdate()). No blocks are destroyed.// TODO: sync gui datamarkers —heatandcurrentOutputare already synced to the client viaNET_GUI_DATA.Testing
Compiled successfully with ForgeGradle (
./gradlew compileJava, exit 0). No gameplay logic change for the non-overheated path; overheat path now idles instead of doing nothing/destroying the block.