Exclude dependency instructions from Mac app#26
Merged
Conversation
Signed-off-by: Joseph Yaksich <gitcommit90@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Exclude dependency-authored
AGENTS.mdinstruction files from the Electron app before signing. The 0.0.18 Cowork dependency graph introducednode_modules/cytoscape/AGENTS.md; the release packager correctly refused to ship it.The exclusion is narrow, keeps the existing fail-closed post-package check, and does not weaken runtime dependency inclusion.
Verification
node --test test/desktop.mjsnpm run typechecknpm run package:macon Apple Silicon diagnostic scratch; packaged app contains noAGENTS.mdgit diff --checkSigned-off-by: Codex codex@openai.com