-
Notifications
You must be signed in to change notification settings - Fork 25
fix: skip empty repositories instead of crashing #591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wjglerum
wants to merge
2
commits into
github-community-projects:main
Choose a base branch
from
wjglerum:fix/empty-repo-404
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thank you. You're right that hardening
check_optional_filealone just moves the crash: an empty repo returnsNonethere, the loop doesn't skip it, and it then hitsrepo.get_contents("/")/.github/workflows/.devcontainerindependabot_file.py, which only catchUnknownObjectException.I've pushed a follow-up that skips empty repos up front instead:
is_empty_repo(repo)helper (repo.size == 0, no extra API call sincesizeis already on the listed repo object).archivedcheck, before anyget_contentslookup, so none of thedependabot_file.pypaths are reached for them.check_optional_fileGithubException404 handling as a defensive backstop.is_empty_repo; full suite passes (184 passed).This felt cleaner than broadening the exception handling at each
get_contentscall site, but happy to switch to a sharedsafe_get_contents-style helper if you'd prefer that centralization.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the shared helper you floated at the end here is worth taking, and I dug up a reason to prefer it over the
size == 0skip.sizeis GitHub's cached disk-usage number (recalculated asynchronously, roughly hourly), so it isn't a reliable stand-in for "no commits." I confirmed against live repos:jsplumb/jsplumbis public, not archived, has a commit and aREADME.md, and still reportssize: 0. The current skip would log it as "empty repository" and pass it over, so Dependabot never gets enabled there, and freshly pushed repos hit the same window until the cache refreshes.A small helper that swallows a 404 from either
UnknownObjectExceptionor the baseGithubExceptioncovers the truly-empty case at every call site without the false positive, so we could drop thesize == 0gate entirely:Then the three
dependabot_file.pyloops becomefor file in list_contents_or_empty(repo, "/"):(and the same for.github/workflowsand.devcontainer), theirtry/except UnknownObjectExceptionblocks go away, andGithubExceptiongets added to the import on line 10. Happy to keep an early skip as well if we base it on a more reliable signal.