Align inline expectation annotations with current query behavior and relearn affected expected outputs#22066
Draft
Copilot wants to merge 2 commits into
Draft
Align inline expectation annotations with current query behavior and relearn affected expected outputs#22066Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Update CodeQL inline expectation tests to match current behavior
Align inline expectation annotations with current query behavior and relearn affected expected outputs
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates stale inline expectation annotations (
// $ ...) so they describe current query behavior, then regenerates the corresponding.expectedfiles via--learnfor the scoped C#, Java (quantum examples), Python, and Ruby tests. The goal is to remove misleadingtestFailuresnoise caused by annotation drift, not to change query/program logic.C# inline expectation cleanup
/csharp/ql/test/utils/inline-tests/InlineTests.csannotations to correctly scope tags and mark known misses withMISSING:where behavior is intentionally not present.PathProblemQuery.expectedPathProblemQueryRelatedLocs.expectedProblemQuery.expectedProblemQueryRelatedLocs.expectedJava quantum example annotation alignment
/java/ql/test/experimental/query-tests/quantum/examples/BadMacUse/BadMacUse.java/java/ql/test/experimental/query-tests/quantum/examples/InsecureOrUnknownNonceSource/InsecureIVorNonceSource.java/java/ql/test/experimental/query-tests/quantum/examples/WeakOrUnknownKDFIterationCount/Test.javaMISSING:, alert placement) to match actual result locations..expectedfiles in these directories.Python/Ruby inline expectation updates
/python/ql/test/experimental/meta/inline-taint-test-demo/taint_test.py/ruby/ql/test/library-tests/dataflow/string-flow/string_flow.rb/ruby/ql/test/library-tests/frameworks/action_controller/filter_flow.rb/ruby/ql/test/library-tests/frameworks/active_support/hash_extensions.rb/ruby/ql/test/library-tests/frameworks/sinatra/views/index.erb/ruby/ql/test/query-tests/experimental/improper-memoization/improper_memoization.rb.expectedfiles to reflect updated inline expectations.Out-of-scope runtime blocker (Kotlin summaries)
-language-version 1.9(current toolchain requires2.0+), so no unreconciled manual.expectededits were introduced there.