JS: Model Sails Action2 inputs as remote sources - #22142
Open
theinfosecguy wants to merge 3 commits into
Open
Conversation
theinfosecguy
force-pushed
the
js-sails-action2-inputs
branch
from
July 9, 2026 05:28
a6406eb to
50eb513
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
theinfosecguy
force-pushed
the
js-sails-action2-inputs
branch
from
July 9, 2026 11:04
5c68227 to
a06a72c
Compare
asgerf
reviewed
Jul 28, 2026
asgerf
left a comment
asgerf
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the PR! Looks reasonable, just need to make some imports private before merging.
Co-authored-by: Asger F <asgerf@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21773.
This adds a Sails Action2 controller model for bulk-exported action objects under
api/controllers. Declaredinputsproperty reads from the actionfnparameter are treated as server request parameters, while helper-shaped modules outside controllers and undeclared input reads are not modeled.Validation:
codeql test run javascript/ql/test/library-tests/frameworks/Sails javascript/ql/test/query-tests/Security/CWE-022/TaintedPath --search-path=/Users/keshavmalik/Documents/codeql --threads=0git diff --check