Go: Reduce package processing log messages to debug level - #22250
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Reduces routine Go package extraction log noise by moving package processing messages to debug-level structured logging.
Changes:
- Replaces two per-package
log.Printfcalls withslog.Debug. - Adds package paths as structured log attributes.
Show a summary per file
| File | Description |
|---|---|
go/extractor/extractor.go |
Moves package processing and type-extraction messages to debug level. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Medium
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the Go extractor logs three lines for every package that is extracted successfully:
In large codebases, this leads to a lot of noise in the output.
This PR moves the first two log messages over to
slog.debugso that they are only output when debug-level logging is enabled.slogis already configured appropriately for the extractor by the existing call toSetLogLevel.