Skip to content

Remove non-strict override from AOAI API key smoke workflow and restore Copilot BYOK env passthrough#41401

Draft
Copilot wants to merge 4 commits into
mainfrom
copilot/remove-strict-false-and-fix-env-support
Draft

Remove non-strict override from AOAI API key smoke workflow and restore Copilot BYOK env passthrough#41401
Copilot wants to merge 4 commits into
mainfrom
copilot/remove-strict-false-and-fix-env-support

Conversation

Copilot AI commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

This PR updates the AOAI API key smoke workflow to run under strict mode and fixes BYOK runtime env handling so Copilot provider variables are available inside AWF. Without this, BYOK provider routing/auth could be dropped by --exclude-env.

  • Strict-mode workflow source update

    • Removed strict: false from smoke-copilot-aoai-apikey.md so the workflow compiles and executes with strict validation defaults.
  • Copilot BYOK env exclusion fix

    • Updated Copilot AWF execution path to stop excluding BYOK provider env vars in BYOK mode:
      • COPILOT_PROVIDER_BASE_URL
      • COPILOT_PROVIDER_API_KEY
      • COPILOT_PROVIDER_BEARER_TOKEN
    • COPILOT_GITHUB_TOKEN exclusion behavior in BYOK mode remains unchanged.
  • Generated workflow alignment

    • Recompiled lock workflows so generated AWF commands reflect the corrected --exclude-env behavior (notably AOAI apikey and AOAI entra smoke lockfiles).
  • Targeted regression coverage

    • Expanded Copilot BYOK execution test assertions to ensure provider env vars are not emitted as --exclude-env flags in AWF BYOK mode.
if isBYOKMode {
    byokProviderEnvVars := map[string]struct{}{
        constants.CopilotProviderBaseURL:     {},
        constants.CopilotProviderAPIKey:      {},
        constants.CopilotProviderBearerToken: {},
    }
    filtered := make([]string, 0, len(excludeEnvVarNames))
    for _, envVarName := range excludeEnvVarNames {
        if _, drop := byokProviderEnvVars[envVarName]; !drop {
            filtered = append(filtered, envVarName)
        }
    }
    excludeEnvVarNames = filtered
}

Copilot AI and others added 3 commits June 25, 2026 06:50
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot AI changed the title Remove strict:false from AOAI apikey smoke workflow and fix BYOK env passthrough Remove non-strict override from AOAI API key smoke workflow and restore Copilot BYOK env passthrough Jun 25, 2026
Copilot AI requested a review from pelikhan June 25, 2026 07:02
@pelikhan

Copy link
Copy Markdown
Collaborator

@copilot remove strict false from the other smoke BYOK workflows

Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>

Copilot AI commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

@copilot remove strict false from the other smoke BYOK workflows

Done in 42cc437 — removed strict: false from the remaining smoke BYOK workflow (smoke-copilot-aoai-entra.md) and recompiled its lockfile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants