Skip to content

Update preset composition strategy reference#3143

Merged
mnriem merged 5 commits into
github:mainfrom
WOLIKIMCHENG:docs/preset-composition-strategies
Jun 25, 2026
Merged

Update preset composition strategy reference#3143
mnriem merged 5 commits into
github:mainfrom
WOLIKIMCHENG:docs/preset-composition-strategies

Conversation

@WOLIKIMCHENG

Copy link
Copy Markdown
Contributor

Summary

  • update the presets reference to describe the implemented composition strategies
  • clarify that templates and commands support prepend, append, and wrap
  • note that scripts support replace and wrap with $CORE_SCRIPT

Testing

  • git diff --check
  • npx markdownlint-cli2 docs/reference/presets.md

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the presets documentation to reflect the currently implemented file composition strategies, replacing the prior “planned for future release” note with a description of how presets can compose templates/commands (prepend/append/wrap) and scripts (replace/wrap via $CORE_SCRIPT).

Changes:

  • Clarifies that preset files are resolved independently per file across the priority stack.
  • Documents supported composition strategies for templates/commands (prepend, append, wrap with {CORE_TEMPLATE}) and scripts (replace, wrap with $CORE_SCRIPT).
Show a summary per file
File Description
docs/reference/presets.md Updates “File Resolution” docs to describe the implemented preset composition strategies and placeholders.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 1/1 changed files
  • Comments generated: 1

Comment thread docs/reference/presets.md Outdated

@mnriem mnriem left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address Copilot feedback

@WOLIKIMCHENG

Copy link
Copy Markdown
Contributor Author

Thanks for the review. Updated the File Resolution section to separate template/script runtime stack lookup from command composition during preset install, before commands are registered. This should address the Copilot feedback.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 1

Comment thread docs/reference/presets.md Outdated
@mnriem

mnriem commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Please address Copilot feedback

@WOLIKIMCHENG

Copy link
Copy Markdown
Contributor Author

Thank you for the follow-up review. I updated the File Resolution text again to avoid implying that command composition always happens before registration. The section now separates the supported composition strategies from when command content is materialized: preset install and post-install/post-removal reconciliation write the effective command content into detected agent directories, while agents do not re-resolve the stack each time a command runs. I appreciate the clarification.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 1

Comment thread docs/reference/presets.md Outdated
@mnriem

mnriem commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Please address Copilot feedback

@WOLIKIMCHENG

Copy link
Copy Markdown
Contributor Author

Thank you for the additional review and clarification. I updated the File Resolution section to make the per-file stack behavior explicit for command, template, and script files before describing their timing differences.

It now clarifies that templates and scripts are looked up when Spec Kit needs them, while commands use the same stack for replacement and composition but are materialized into detected agent directories: preset install registers the command files, and post-install/post-removal reconciliation recalculates affected command names from the active stack and writes the effective content. I also tightened the disable/remove FAQ so it does not imply that disabling a preset stops previously registered commands.

I appreciate the continued guidance.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 1

Comment thread docs/reference/presets.md Outdated
@mnriem

mnriem commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Please address Copilot feedback

@WOLIKIMCHENG

Copy link
Copy Markdown
Contributor Author

Thanks for the review. I updated the wording to clarify that reconciliation recomputes and writes the effective command content for affected command names, rather than recalculating the command names themselves.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 0 new

@mnriem mnriem self-requested a review June 25, 2026 15:12
@mnriem mnriem merged commit 7624dd6 into github:main Jun 25, 2026
12 checks passed
@mnriem

mnriem commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants