Skip to content

fix(events): skip unreadable extension manifests - #4089

Open
marcelsafin wants to merge 1 commit into
github:mainfrom
marcelsafin:fix/extension-event-read-oserror
Open

fix(events): skip unreadable extension manifests#4089
marcelsafin wants to merge 1 commit into
github:mainfrom
marcelsafin:fix/extension-event-read-oserror

Conversation

@marcelsafin

Copy link
Copy Markdown
Contributor

Description

The raw-manifest fallback in collect_extension_events() skips malformed YAML and undecodable text, but an OSError from reading the same optional extension.yml escapes and aborts event collection.

This handles read failures at the existing best-effort boundary, so one inaccessible extension manifest does not block events from the rest of the project.

Testing

  • Tested locally with uv run specify --help
  • Ran existing tests with uv sync && uv run pytest (6,652 passed, 177 skipped)
  • Added an unreadable-manifest regression using a targeted Path.read_text failure
  • uvx ruff@0.15.0 check src tests clean

AI Disclosure

  • I did not use AI assistance for this contribution
  • I did use AI assistance (describe below)

Implemented autonomously by GitHub Copilot CLI (model: GPT-5.6 Sol) under human direction; a failing regression was added before the fix, then the full suite and lint were run locally. Commit includes Assisted-by and Co-authored-by trailers.

Assisted-by: GitHub Copilot (model: gpt-5.6-sol, autonomous)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings August 12, 2026 22:05
@marcelsafin
marcelsafin requested a review from mnriem as a code owner August 12, 2026 22:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Handles unreadable optional extension manifests without aborting event collection.

Changes:

  • Catches OSError when reading raw manifests.
  • Adds regression coverage for read failures.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/specify_cli/events.py Skips manifests that cannot be read.
tests/integrations/test_events.py Tests unreadable-manifest handling.

馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants