Skip to content

fix(bundler): reject unsupported catalog payload versions - #4090

Open
marcelsafin wants to merge 1 commit into
github:mainfrom
marcelsafin:fix/bundle-catalog-payload-schema-version
Open

fix(bundler): reject unsupported catalog payload versions#4090
marcelsafin wants to merge 1 commit into
github:mainfrom
marcelsafin:fix/bundle-catalog-payload-schema-version

Conversation

@marcelsafin

Copy link
Copy Markdown
Contributor

Description

Bundle catalog payloads can declare schema_version, but the loader currently ignores it and parses future incompatible formats under current assumptions.

This rejects unsupported major versions before reading entries. Payloads without a version remain accepted for backward compatibility, and compatible 1.x payloads retain current behavior.

Testing

  • Tested locally with uv run specify --help
  • Ran existing tests with uv sync && uv run pytest (6,652 passed, 177 skipped)
  • Added a contract regression for an unsupported 2.0 payload
  • uvx ruff@0.15.0 check src tests clean

AI Disclosure

  • I did not use AI assistance for this contribution
  • I did use AI assistance (describe below)

Implemented autonomously by GitHub Copilot CLI (model: GPT-5.6 Sol) under human direction; a failing contract regression was added before the fix, then the full suite and lint were run locally. Commit includes Assisted-by and Co-authored-by trailers.

Assisted-by: GitHub Copilot (model: gpt-5.6-sol, autonomous)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings August 12, 2026 22:05
@marcelsafin
marcelsafin requested a review from mnriem as a code owner August 12, 2026 22:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Rejects incompatible bundle catalog schema versions while preserving support for versionless and 1.x payloads.

Changes:

  • Adds catalog schema major-version validation.
  • Adds a regression test for unsupported 2.0 payloads.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/specify_cli/bundler/models/catalog.py Validates catalog payload schema versions before parsing entries.
tests/contract/test_catalog_schema.py Tests rejection of unsupported schema versions.

馃挕 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants