feat: expose publishNotReadyAddresses for broker services (#244)#1
Open
gomitrah wants to merge 2 commits into
Open
feat: expose publishNotReadyAddresses for broker services (#244)#1gomitrah wants to merge 2 commits into
gomitrah wants to merge 2 commits into
Conversation
gomitrah
force-pushed
the
feat/expose-publish-not-ready-addresses
branch
from
July 15, 2026 06:51
a4d324a to
fd22b43
Compare
* chore(e2e): reduce log noise from kubectl output Terratest echoes every stdout line of the kubectl commands it runs. Two spots dominated the e2e log volume: - listK8sResourceKinds dumped ~100+ api-resource names per call, twice per cluster snapshot. - getBrokerConfigMapLogDirs dumped the full broker-config ConfigMap for all 3 brokers on every multi-disk-removal poll iteration. Both now use the existing runKubectlSilent bypass. The multi-disk poller additionally logs only the parsed log.dirs, which is all it inspects. Also removes the dead setupReducedLogging(): its TEST_LOG_LEVEL / KUBECTL_* env vars have no effect on terratest v1.0.1's logger, which is why the line-dumping persisted. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(e2e): trim trailing newline in listK8sResourceKinds output runKubectlSilent uses cmd.Output(), which preserves kubectl's trailing newline (terratest's runner stripped it). listK8sResourceKinds split on "\n" without trimming, producing an empty-string kind element that got joined into the `kubectl get` args during cluster snapshotting: error: the server doesn't have a resource type "" TrimRight the trailing newline before splitting, matching getK8sResources and getK8sResourcesQuiet. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(e2e): harden listK8sCRDs output parsing listK8sCRDs split kubectl output on "\n" without trimming the trailing newline and without dropping warning lines - the same latent bug fixed in listK8sResourceKinds. It currently uses terratest's runner (which strips the trailing newline) so it isn't broken today, but it would break the moment it's switched to runKubectlSilent. TrimRight the trailing newline, guard empty output, and run kubectlRemoveWarnings - consistent with getK8sResources and getK8sResourcesQuiet. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
gomitrah
force-pushed
the
feat/expose-publish-not-ready-addresses
branch
from
July 17, 2026 08:24
fd22b43 to
a85e688
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a
publishNotReadyAddressesfield to theKafkaClusterCRD spec and propagates it to thenon-headless broker Services created by the operator: the per-broker Services (
kafka-{id}) andkafka-all-broker.Type of Change
Checklist