Improve the LaunchSingleInstance in cvd start#2812
Open
SuperStrongDinosaur wants to merge 1 commit into
Open
Conversation
Databean
reviewed
Jul 6, 2026
SuperStrongDinosaur
force-pushed
the
startSingleInstanceFix
branch
from
77bb300 to
4b6bdf1
Compare
Databean
approved these changes
Jul 9, 2026
| return false; | ||
| } | ||
|
|
||
| auto instances = group.Instances(); |
Member
There was a problem hiding this comment.
nit: the style guide writes
Use type deduction only if it makes the code clearer to readers who aren't familiar with the project, or if it makes the code safer. Do not use it merely to avoid the inconvenience of writing an explicit type.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change improves the robustness of the single-instance boot (LaunchSingleInstance) in
cvd start:Refine Bypass Validation Checks:
- Prevented bypass if the user requests foreground mode (
--daemon=false), sinceLaunchSingleInstancedoes not implement foreground log tailing.- Prevented bypass if any configuration-altering flags are passed (only
--daemonis considered safe), ensuringassemble_cvdis not skipped when config changes are requested.- Enforce that the main instance itself cannot bypass the full boot, and that the main instance must be in
RUNNINGstate before a secondary instance is allowed to use the fast-track bypass.