Start enforcing BUILD.bazel file formatting within bazel on some files#2825
Merged
Conversation
cjreynol
approved these changes
Jul 9, 2026
Databean
force-pushed
the
bazel_test_buildifier
branch
from
cbd9818 to
544b3d9
Compare
Member
Author
|
Thanks for reviewing! |
Build format tests are currently run through github actions. Making it part of the bazel build will make it easier to reproduce and iterate on locally. Bug: b/532697459
This is more concise to use. Bug: b/532697459
Bug: b/532697459
Bug: b/532697459
Bug: b/532697459
Databean
force-pushed
the
bazel_test_buildifier
branch
from
544b3d9 to
cda02ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently have a github action that enforces BUILD.bazel file formatting. It would be better if this validation happened within bazel itself, so developers can locally run
bazel test //...to validateBUILD.bazelfiles without needing to go to GitHub.This has the downside that
buildifierwill sometimes try to fix files in-place, which does not work and fails with this opaque error:Opening
<path redacted>/test.logdoes not have more information besides what is shown in the error.Bug: b/532697459