fix: exclude channel 76 from default CS channel_map (Core Spec 6.0 compliance)#950
Open
dcaayushd wants to merge 1 commit into
Open
fix: exclude channel 76 from default CS channel_map (Core Spec 6.0 compliance)#950dcaayushd wants to merge 1 commit into
dcaayushd wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #945
the default channel_map in Device.create_cs_config() had byte 9 set
to 0x15 which enables channel 76. Core Spec 6.0 Vol 4 Part E §7.8.117
requires channels 0,1,23,24,25,76,77,78 to be excluded from the CS
Channel_Map. strict controllers (e.g. Nordic nRF54L15) correctly reject
the command with UNSUPPORTED_FEATURE_OR_PARAMETER_VALUE_ERROR (0x11).
fix: change byte 9 from 0x15 to 0x05, keeping only channels 72 and 74
enabled in that byte. same even-numbered channel pattern, now spec-compliant.
added a test verifying the default map has no overlap with the forbidden
channel set.