[Swarming] Decouples linux from android_emulator fuzzing#5347
Open
IvanBM18 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This small PR focuses on re enabling linux fuzzing in swarming by decoupling the linux jobs from automatically being treated as android jobs.
Previously we always booted up an al emulator on every single job that reached swarming(as per the config's specs) and we always used the
OS_OVERRIDE:ANDROIDenv var, so that clusterfuzz followed the setup/logic decisions of a android device. This had 2 issues:PLATFORM=LINUXso that CF could send a swarming request targeting a Linux bot(which contained our emulated devices)Changes
job.platformis android_emulator we override is target swarming bot OS to linux in the swarming request, which is the one that contains the emulator setup logic.Note
This Pr is dependant of this other config pr
Which adds the config specs for android emulator jobs
Tests performed
Since this type of change is more focused on swarming.yaml config changes i tested this by creating a new job using the
ANDROID_EMULATORplatform and i verified if it was correctly scheduled in a linux swarming bot, and that said bot launched the emulator and also that the fuzzing task executed successfullySee the logs