test: run the google-cloud-dns system tests in google cloud build#8703
test: run the google-cloud-dns system tests in google cloud build#8703danieljbruce wants to merge 15 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a Cloud Build configuration (cloudbuild.yaml) for the handwritten/google-cloud-dns service to automate dependency installation, system testing, and optional code coverage reporting. The reviewer's feedback focuses on cleaning up the configuration by removing commented-out boilerplate code, placeholder comments, and dummy echo statements related to Secret Manager and Codecov integration.
| # If you need specific credentials from Secret Manager, uncomment these: | ||
| # - 'GOOGLE_APPLICATION_CREDENTIALS=/secrets/sa-key.json' | ||
| id: 'run-system-tests' | ||
| waitFor: ['install-dependencies'] | ||
| # For Secret Manager, uncomment these (adjust secret name and volume path as needed): | ||
| # secretEnv: ['SA_KEY'] | ||
| # volumes: | ||
| # - name: 'sa-keys' | ||
| # path: '/secrets' |
There was a problem hiding this comment.
These commented-out boilerplate instructions and configuration options for Secret Manager should be removed to keep the configuration clean and maintainable.
id: 'run-system-tests'
waitFor: ['install-dependencies']There was a problem hiding this comment.
This code change is no longer here.
| # The original codecov.sh script from Kokoro needs to be made available to GCB. | ||
| # Options: | ||
| # a) Commit codecov.sh into your repo (e.g., .kokoro/codecov.sh) and call it: | ||
| # if [ -f .kokoro/codecov.sh ]; then . ./.kokoro/codecov.sh; fi | ||
| # b) Replicate its functionality directly in this step. | ||
| # c) Store it in a GCS bucket and fetch it. | ||
| echo "Codecov reporting (if desired) would be integrated here." |
There was a problem hiding this comment.
Remove the placeholder comments and dummy echo statement regarding Codecov integration to keep the build configuration clean and production-ready.
There was a problem hiding this comment.
We are just going to keep this consistent with the other PRs and leave it as is.
| # If you use Secret Manager for credentials, uncomment and configure: | ||
| # availableSecrets: | ||
| # secretManager: | ||
| # - versionName: projects/${PROJECT_ID}/secrets/YOUR_SERVICE_ACCOUNT_KEY_SECRET_NAME/versions/latest | ||
| # env: 'SA_KEY' # This env var will hold the secret value. Use it as GOOGLE_APPLICATION_CREDENTIALS in step 3 if needed. |
There was a problem hiding this comment.
Remove these commented-out Secret Manager boilerplate configuration lines to keep the configuration file clean.
danieljbruce
changed the title
danieljbruce
left a comment
danieljbruce
left a comment
There was a problem hiding this comment.
Responded to gemini
| # The original codecov.sh script from Kokoro needs to be made available to GCB. | ||
| # Options: | ||
| # a) Commit codecov.sh into your repo (e.g., .kokoro/codecov.sh) and call it: | ||
| # if [ -f .kokoro/codecov.sh ]; then . ./.kokoro/codecov.sh; fi | ||
| # b) Replicate its functionality directly in this step. | ||
| # c) Store it in a GCS bucket and fetch it. | ||
| echo "Codecov reporting (if desired) would be integrated here." |
There was a problem hiding this comment.
We are just going to keep this consistent with the other PRs and leave it as is.
| # If you use Secret Manager for credentials, uncomment and configure: | ||
| # availableSecrets: | ||
| # secretManager: | ||
| # - versionName: projects/${PROJECT_ID}/secrets/YOUR_SERVICE_ACCOUNT_KEY_SECRET_NAME/versions/latest | ||
| # env: 'SA_KEY' # This env var will hold the secret value. Use it as GOOGLE_APPLICATION_CREDENTIALS in step 3 if needed. |
1 participant
Description
This pull request adds a yaml file to instruct the Google Cloud DNS system test CI check to work with the new Cloud Build trigger thereby making the new CI check effectively run our system tests. The new test environment caused tests to fail so we will skip those tests and address them later in this bug.
Impact
Leverages the strengths of running system tests in GCB rather than relying on kokoro for system tests.
Testing
This pull request tells the tests how to work with the new check to the continuous integration pipeline for the Google Cloud DNS system tests thus improves the effectiveness of that test.
Next Steps