chore: owlbot copy google-cloud-workflows#8796
Open
JoeWang1127 wants to merge 10 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the auto-generated WorkflowsClient for both v1 and v1beta versions of the Google Cloud Workflows service, along with their corresponding configurations, tests, and updated documentation. The code review feedback highlights critical issues with the entry point files: the main src/index.ts contains duplicated imports and exports of v1 and v1beta which will cause TypeScript compilation failures, and the newly added WorkflowsClient is not exported from src/index.ts, v1/index.ts, or v1beta/index.ts. The reviewer recommends addressing these missing and duplicated exports upstream in the generator or templates to prevent them from being overwritten in future regenerations.
0f9238b to
9f53165
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copy google-cloud-workflows from googleapis-gen, added
librarian.jsto fix index.ts and remove unused clients.googleapis commit (same as the one in
librarian.yaml).googleapis-gen commit.
Step to copy the code:
For googleapis/librarian#6278