Skip to content

chore: owlbot copy google-cloud-workflows#8796

Open
JoeWang1127 wants to merge 10 commits into
googleapis:mainfrom
JoeWang1127:chore/copy-google-cloud-workflows
Open

chore: owlbot copy google-cloud-workflows#8796
JoeWang1127 wants to merge 10 commits into
googleapis:mainfrom
JoeWang1127:chore/copy-google-cloud-workflows

Conversation

@JoeWang1127

@JoeWang1127 JoeWang1127 commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Copy google-cloud-workflows from googleapis-gen, added librarian.js to fix index.ts and remove unused clients.

googleapis commit (same as the one in librarian.yaml).
googleapis-gen commit.

Step to copy the code:

docker run --rm --user $(id -u):$(id -g) -v .:/repo -w /repo -v ../googleapis-gen:/googleapis-gen --env HOME=/tmp gcr.io/cloud-devrel-public-resources/owlbot-cli:latest copy-code  --source-repo=/googleapis-gen --config-file=packages/google-cloud-workflows/.OwlBot.yaml

docker run --rm --user $(id -u):$(id -g) -v $(pwd):/repo -w /repo   --env HOME=/tmp   gcr.io/cloud-devrel-public-resources/owlbot-nodejs-mono-repo:latest packages/google-cloud-workflows

For googleapis/librarian#6278

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the auto-generated WorkflowsClient for both v1 and v1beta versions of the Google Cloud Workflows service, along with their corresponding configurations, tests, and updated documentation. The code review feedback highlights critical issues with the entry point files: the main src/index.ts contains duplicated imports and exports of v1 and v1beta which will cause TypeScript compilation failures, and the newly added WorkflowsClient is not exported from src/index.ts, v1/index.ts, or v1beta/index.ts. The reviewer recommends addressing these missing and duplicated exports upstream in the generator or templates to prevent them from being overwritten in future regenerations.

Comment thread packages/google-cloud-workflows/src/index.ts Outdated
Comment thread packages/google-cloud-workflows/src/v1/index.ts
Comment thread packages/google-cloud-workflows/src/v1beta/index.ts
@JoeWang1127 JoeWang1127 marked this pull request as ready for review July 3, 2026 21:56
@JoeWang1127 JoeWang1127 requested a review from a team as a code owner July 3, 2026 21:56
@JoeWang1127 JoeWang1127 force-pushed the chore/copy-google-cloud-workflows branch from 0f9238b to 9f53165 Compare July 3, 2026 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant