Skip to content

test(storage): test open_object single request/response - #6169

Merged
joshuatants merged 1 commit into
googleapis:mainfrom
joshuatants:open_object_grpc_tests
Jul 28, 2026
Merged

test(storage): test open_object single request/response#6169
joshuatants merged 1 commit into
googleapis:mainfrom
joshuatants:open_object_grpc_tests

Conversation

@joshuatants

@joshuatants joshuatants commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@product-auto-label product-auto-label Bot added the api: storage Issues related to the Cloud Storage API. label Jul 27, 2026
@joshuatants joshuatants changed the title test(storage): test open_object request contract test(storage): test open_object single request/response Jul 27, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new integration test send_and_read_single_response_success and a helper function assert_request_metadata to verify successful single-response reads and validate request metadata. The feedback suggests improving test robustness and readability by avoiding direct indexing on HeaderMap to prevent generic panics, and preferring literal strings over complex formatting logic or variables for assertions.

Comment thread src/storage/tests/open_object_grpc.rs
Comment thread src/storage/tests/open_object_grpc.rs
@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.57%. Comparing base (49cc805) to head (32b00d3).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6169   +/-   ##
=======================================
  Coverage   96.57%   96.57%           
=======================================
  Files         264      264           
  Lines       66496    66496           
=======================================
+ Hits        64217    64220    +3     
+ Misses       2279     2276    -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@joshuatants
joshuatants marked this pull request as ready for review July 27, 2026 05:35
@joshuatants
joshuatants requested review from a team as code owners July 27, 2026 05:35
Comment thread src/storage/tests/open_object_grpc.rs
@vsharonlynn

Copy link
Copy Markdown
Contributor

LGTM.

@joshuatants
joshuatants merged commit dec0817 into googleapis:main Jul 28, 2026
41 checks passed
@joshuatants
joshuatants deleted the open_object_grpc_tests branch July 28, 2026 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants