Skip to content

feat(storage): add runner script and docs for appendable upload benchmark - #6171

Draft
vsharonlynn wants to merge 3 commits into
googleapis:mainfrom
vsharonlynn:appendable_upload_benchmark_4
Draft

feat(storage): add runner script and docs for appendable upload benchmark#6171
vsharonlynn wants to merge 3 commits into
googleapis:mainfrom
vsharonlynn:appendable_upload_benchmark_4

Conversation

@vsharonlynn

@vsharonlynn vsharonlynn commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

This PR comes after PR #6170.

Issue #5716.

@product-auto-label product-auto-label Bot added the api: storage Issues related to the Cloud Storage API. label Jul 27, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new benchmark crate, storage-benchmark-appendable-object, to measure Google Cloud Storage appendable upload performance under various chunk sizes. The feedback suggests creating the output directory recursively before writing the CSV report to prevent potential runtime failures, and adding a lifecycle rule to the bucket setup instructions in the README to automatically delete uploaded objects and avoid unnecessary storage costs.

Comment thread src/storage/benchmarks/appendable_object/src/reporter.rs Outdated
Comment on lines +20 to +26
gcloud storage buckets create gs://${BUCKET_NAME} \
--location=${ZONE} \
--placement=zone \
--default-storage-class=RAPID \
--hierarchical-namespace \
--uniform-bucket-level-access
```

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since each run of the benchmark uploads multiple large objects (e.g., 100 x 100 MiB = 10 GiB), these objects will accumulate in the zonal bucket and incur storage costs. It is highly recommended to configure a lifecycle rule on the bucket to automatically delete objects after 1 day.

Suggested change
gcloud storage buckets create gs://${BUCKET_NAME} \
--location=${ZONE} \
--placement=zone \
--default-storage-class=RAPID \
--hierarchical-namespace \
--uniform-bucket-level-access
```
gcloud storage buckets create gs://${BUCKET_NAME} \
--location=${ZONE} \
--placement=zone \
--default-storage-class=RAPID \
--hierarchical-namespace \
--uniform-bucket-level-access
# Add a lifecycle rule to delete objects after 1 day to avoid storage costs
echo '{"rule": [{"action": {"type": "Delete"}, "condition": {"age": 1}}]}' > lifecycle.json
gcloud storage buckets update gs://${BUCKET_NAME} --lifecycle-file=lifecycle.json
rm lifecycle.json

@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.59%. Comparing base (dec0817) to head (fa01ebe).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6171   +/-   ##
=======================================
  Coverage   96.58%   96.59%           
=======================================
  Files         266      266           
  Lines       66852    66852           
=======================================
+ Hits        64571    64574    +3     
+ Misses       2281     2278    -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@vsharonlynn
vsharonlynn force-pushed the appendable_upload_benchmark_4 branch 2 times, most recently from b64cbd3 to 1371208 Compare July 27, 2026 13:01
@vsharonlynn
vsharonlynn force-pushed the appendable_upload_benchmark_4 branch from 1371208 to fa01ebe Compare July 28, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant