Skip to content

ci: retry spanner emulator fetch - #6187

Open
dbolduc wants to merge 3 commits into
googleapis:mainfrom
dbolduc:ci-spanner-emulator-retry
Open

ci: retry spanner emulator fetch#6187
dbolduc wants to merge 3 commits into
googleapis:mainfrom
dbolduc:ci-spanner-emulator-retry

Conversation

@dbolduc

@dbolduc dbolduc commented Jul 27, 2026

Copy link
Copy Markdown
Member

Fixes #6185

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a retry loop with exponential backoff when starting the Spanner Emulator in the integration test configuration. However, capturing standard error (2>&1) into the CONTAINER variable can cause subsequent commands to fail if warnings are printed to stderr. It is recommended to only capture standard output.

Comment thread .gcb/integration.yaml Outdated
@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.58%. Comparing base (505ebf1) to head (147cfd3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6187      +/-   ##
==========================================
- Coverage   96.59%   96.58%   -0.01%     
==========================================
  Files         266      266              
  Lines       66852    66852              
==========================================
- Hits        64574    64570       -4     
- Misses       2278     2282       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbolduc
dbolduc marked this pull request as ready for review July 27, 2026 17:34
@dbolduc
dbolduc requested a review from a team as a code owner July 27, 2026 17:34
@dbolduc

dbolduc commented Jul 27, 2026

Copy link
Copy Markdown
Member Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a retry loop with exponential backoff when starting the Spanner Emulator in the integration test workflow to handle transient failures. The reviewer suggests refactoring this to retry only the docker pull command instead of the entire docker run command, which avoids creating orphaned containers and more directly targets potential network issues.

Comment thread .gcb/integration.yaml
@dbolduc

dbolduc commented Jul 27, 2026

Copy link
Copy Markdown
Member Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a retry mechanism with exponential backoff (up to 5 attempts) when pulling the Spanner Emulator Docker image in the integration workflow, reducing build failures caused by transient network issues. I have no further feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flake fetching spanner emulator

1 participant