ci: retry spanner emulator fetch - #6187
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a retry loop with exponential backoff when starting the Spanner Emulator in the integration test configuration. However, capturing standard error (2>&1) into the CONTAINER variable can cause subsequent commands to fail if warnings are printed to stderr. It is recommended to only capture standard output.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6187 +/- ##
==========================================
- Coverage 96.59% 96.58% -0.01%
==========================================
Files 266 266
Lines 66852 66852
==========================================
- Hits 64574 64570 -4
- Misses 2278 2282 +4 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a retry loop with exponential backoff when starting the Spanner Emulator in the integration test workflow to handle transient failures. The reviewer suggests refactoring this to retry only the docker pull command instead of the entire docker run command, which avoids creating orphaned containers and more directly targets potential network issues.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces a retry mechanism with exponential backoff (up to 5 attempts) when pulling the Spanner Emulator Docker image in the integration workflow, reducing build failures caused by transient network issues. I have no further feedback to provide.
Fixes #6185