Skip to content

chore: Mock gcs client to deflake unit test in gcs_utils.py #6954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Jun 29, 2026
+7 −2
Merged

chore: Mock gcs client to deflake unit test in gcs_utils.py #6954

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions tests/unit/aiplatform/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,8 @@ def mock_storage_blob_upload_from_filename():
"google.cloud.storage.Blob.upload_from_filename"
) as mock_blob_upload_from_filename, patch(
"google.cloud.storage.Bucket.exists", return_value=True
), patch(
"google.cloud.storage.Client.__init__", return_value=None
):
yield mock_blob_upload_from_filename

Expand Down Expand Up @@ -125,7 +127,9 @@ def mock_storage_client_list_blob():
def mock_storage_blob_download_to_filename():
with patch(
"google.cloud.storage.Blob.download_to_filename"
) as mock_blob_download_to_filename:
) as mock_blob_download_to_filename, patch(
"google.cloud.storage.Client.__init__", return_value=None
):
yield mock_blob_download_to_filename


Expand Down Expand Up @@ -644,7 +648,8 @@ def test_download_from_gcs_file(
filename=destination_path
)

def test_download_from_gcs_invalid_source_uri(self):
@mock.patch("google.cloud.storage.Client.__init__", return_value=None)
def test_download_from_gcs_invalid_source_uri(self, _mock_client_init):
with tempfile.TemporaryDirectory() as temp_dir:
source_uri = f"{GCS_BUCKET}/{GCS_PREFIX}"
destination_path = f"{temp_dir}/test-dir"
Expand Down
Loading