Fix ordering of Gemini inlined batch responses#2124
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
Hi @neo-con, Thanks for reaching out us! Looks like the branch is out of date, Can you please update the branch. |
7f21787 to
a586dd0
Compare
|
updated branch, thnx |
a586dd0 to
977451c
Compare
|
Hi @neo-con is this branch merged? btw, thank you for your support |
|
This pull request has been marked as stale because it has been inactive for 14 days with no activity. It will be closed in 2 days if no further activity occurs. |
|
This pull request was closed because it has been inactive for 16 days. Please reopen or submit a new PR if you need further assistance. Thanks! |
Summary
Fixes #1909.
The Gemini API can return
inlinedResponsesout of request order for batch jobs that useinlined_requests. This change preserves the original request order by stamping an SDK-reserved order marker on each inlined request and reordering returned inlined responses by that marker when the full marker set is present and valid.This change keeps the behavior conservative:
Changes
Testing