Skip to content

Docs2#95

Merged
chrisamiller merged 16 commits into
griffithlab:masterfrom
chrisamiller:docs2
Jul 10, 2026
Merged

Docs2#95
chrisamiller merged 16 commits into
griffithlab:masterfrom
chrisamiller:docs2

Conversation

@chrisamiller

Copy link
Copy Markdown
Collaborator

Adding lots of examples to the documentation, along with a minimal set of VCFs and inputs to run all of the examples.

Also includes an amalgamation of minor issue fixes that came from getting the examples to run cleanly and intuitively (no unneeded warnings, etc):

  1. replaces typo of "Gene Expressions" with "Gene Expression" for the GX field (and updates tests accordingly)

  2. updates the mismatch reporter tool to remove extra "INFO:root:" output at the top of the report

  3. removes some warnings that were not useful/unnecessary from several tools

  4. fixed a bug in vcf_info_annotator. When using --overwrite, the indices internal to vcfpy weren't getting updated correctly, so trying to remove the old header line caused a dangling reference and an error. Fixed by rebuilding the indices.

@susannasiebert susannasiebert left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for now this is fine, but it's probably preferable/more robust to use vcfpy here. Maybe a stretch goal to do in the future.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good suggestion - I didn't think that hard about this (quick and dirty script for internal use, etc), but it makes sense. Flipped it around to use vcfpy to be consistent with the rest of the package. Fixed it up.

@susannasiebert susannasiebert left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, again

@chrisamiller chrisamiller merged commit 4db5c72 into griffithlab:master Jul 10, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants