Skip to content

Make self hosted video poster image and fallback image optional #16327

Open
abeddow91 wants to merge 3 commits into
mainfrom
ab/optional-poster-image
Open

Make self hosted video poster image and fallback image optional #16327
abeddow91 wants to merge 3 commits into
mainfrom
ab/optional-poster-image

Conversation

@abeddow91

@abeddow91 abeddow91 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

What does this change?

Make self hosted video poster image and fallback image optional

Why?

MAM does not require these fields so this better reflects the state of the atom in CAPI.

This also allows videos in articles to render if a poster image is not available. Previously, videos without a poster image in article returned null to handle the required type.

Screenshots

Before After
before-mobile after-mobile

…ool and allow videos to render in article without these images.
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@abeddow91 abeddow91 self-assigned this Jul 6, 2026
@abeddow91 abeddow91 added the feature Departmental tracking: work on a new feature label Jul 6, 2026

@Fweddi Fweddi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - how does this look in a case where a video is trying to fall back to an undefined card picture - a grey box?

@abeddow91 abeddow91 added the run_chromatic Runs chromatic when label is applied label Jul 8, 2026
@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Jul 8, 2026
@akash1810

akash1810 commented Jul 9, 2026

Copy link
Copy Markdown
Member

Please rebase this branch against main before deploying to CODE. #16321 made some changes to CI and infrastructure. Deploying this branch without these changes present will either:

  • Fail when using Riff-Raff's default update strategy
  • OR delete the new infrastructure if using Riff-Raff's "dangerous" mode

Please rebase this branch against main before deploying to CODE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Departmental tracking: work on a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants