FE-1272: Predicate firing-time info box says the transition fires immediately - #9097
Open
claude[bot] wants to merge 1 commit into
Open
FE-1272: Predicate firing-time info box says the transition fires immediately#9097claude[bot] wants to merge 1 commit into
claude[bot] wants to merge 1 commit into
Conversation
State explicitly that a predicate-guarded transition fires immediately — without stochastic delay — once the guard returns true and input tokens are available. The previous copy only said it "fires when this function returns true", which left the timing ambiguous next to the Stochastic Rate option.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
PR SummaryLow Risk Overview Adds a patch changeset for Reviewed by Cursor Bugbot for commit 3bbfc59. Bugbot is set up for automated code reviews on this repo. Configure here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Yannis Zachos · Slack thread
🌟 What is the purpose of this PR?
Clarify the Predicate firing-time info box in Petrinaut's transition properties panel: predicate-guarded transitions fire without stochastic delay, and users choosing between "Predicate" and "Stochastic Rate" should know that.
Before:
After:
🔗 Related links
🚫 Blocked by
🔍 What does this change?
libs/@hashintel/petrinaut/src/ui/views/Editor/panels/PropertiesPanel/transition-properties/subviews/transition-firing-time/subview.tsx@hashintel/petrinautPre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
(The user docs already describe this behaviour —
libs/@hashintel/petrinaut/docs/petri-net-extensions.mdstates "The transition fires immediately when it returnstrue." This PR brings the in-app copy in line with the docs.)🕸️ Does this require a change to the Turbo Graph?
The changes in this PR:
None
🐾 Next steps
None
🛡 What tests cover this?
❓ How to test this?
yarn devinlibs/@hashintel/petrinaut)📹 Demo
Copy-only change; the info box renders the new sentence as quoted above.
Generated by Claude Code