Skip to content

FE-1272: Predicate firing-time info box says the transition fires immediately - #9097

Open
claude[bot] wants to merge 1 commit into
mainfrom
claude/fe-1272-predicate-copy-fires-immediately
Open

FE-1272: Predicate firing-time info box says the transition fires immediately#9097
claude[bot] wants to merge 1 commit into
mainfrom
claude/fe-1272-predicate-copy-fires-immediately

Conversation

@claude

@claude claude Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Requested by Yannis Zachos · Slack thread

🌟 What is the purpose of this PR?

Clarify the Predicate firing-time info box in Petrinaut's transition properties panel: predicate-guarded transitions fire without stochastic delay, and users choosing between "Predicate" and "Stochastic Rate" should know that.

Before:

Define a boolean guard condition. The transition fires when this function returns true, enabling discrete control flow based on token data.

After:

Define a boolean guard condition. The transition fires immediately — without stochastic delay — once this function returns true and input tokens are available.

🔗 Related links

🚫 Blocked by

  • Nothing

🔍 What does this change?

  • Updates the Predicate info-box string in libs/@hashintel/petrinaut/src/ui/views/Editor/panels/PropertiesPanel/transition-properties/subviews/transition-firing-time/subview.tsx
  • Adds a patch changeset for @hashintel/petrinaut

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • modifies an npm-publishable library and I have added a changeset file(s)

📜 Does this require a change to the docs?

The changes in this PR:

  • are internal and do not require a docs change

(The user docs already describe this behaviour — libs/@hashintel/petrinaut/docs/petri-net-extensions.md states "The transition fires immediately when it returns true." This PR brings the in-app copy in line with the docs.)

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph

⚠️ Known issues

None

🐾 Next steps

None

🛡 What tests cover this?

  • None — copy-only string change, no logic affected

❓ How to test this?

  1. Checkout the branch and run the Petrinaut demo (yarn dev in libs/@hashintel/petrinaut)
  2. Select a transition, expand the "Firing Time" subview, and choose "Predicate"
  3. Confirm the info box reads: "Define a boolean guard condition. The transition fires immediately — without stochastic delay — once this function returns true and input tokens are available."

📹 Demo

Copy-only change; the info box renders the new sentence as quoted above.


Generated by Claude Code

State explicitly that a predicate-guarded transition fires immediately —
without stochastic delay — once the guard returns true and input tokens
are available. The previous copy only said it "fires when this function
returns true", which left the timing ambiguous next to the Stochastic
Rate option.
@vercel

vercel Bot commented Jul 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hash Ready Ready Preview, Comment Jul 24, 2026 5:12pm
petrinaut Ready Ready Preview, Comment Jul 24, 2026 5:12pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
hashdotdesign-tokens Ignored Ignored Jul 24, 2026 5:12pm

@github-actions github-actions Bot added area/infra Relates to version control, CI, CD or IaC (area) area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team labels Jul 24, 2026
@claude
claude Bot marked this pull request as ready for review July 24, 2026 17:17
@claude
claude Bot requested a review from kube July 24, 2026 17:17
@cursor

cursor Bot commented Jul 24, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Copy-only UI string and changeset; no execution, auth, or data-handling logic is modified.

Overview
Updates the Predicate help text in the transition Firing Time properties panel so it matches documented behavior: the transition fires immediately (no stochastic delay) when the guard returns true and input tokens are available.

Adds a patch changeset for @hashintel/petrinaut. No runtime or editor logic changes.

Reviewed by Cursor Bugbot for commit 3bbfc59. Bugbot is set up for automated code reviews on this repo. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/infra Relates to version control, CI, CD or IaC (area) area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team

Development

Successfully merging this pull request may close these issues.

2 participants