Skip to content

H-6683: Add value column to parameter table; more slideover CSS fixes - #9113

Merged
CiaranMn merged 5 commits into
mainfrom
cm/value-column-for-parameters
Jul 27, 2026
Merged

H-6683: Add value column to parameter table; more slideover CSS fixes#9113
CiaranMn merged 5 commits into
mainfrom
cm/value-column-for-parameters

Conversation

@CiaranMn

Copy link
Copy Markdown
Member

🌟 What is the purpose of this PR?

  1. Adds a 'value' column to the planning parameter table, to help understand the scale of material affected by the parameter (whether procured, produced, shipped, etc)
  2. Fix further styling regressions caused by PandaCSS changes, including slideover animation

Pre-Merge Checklist 🚀

🚢 Has this modified a publishable library?

This PR:

  • does not modify any publishable blocks or libraries, or modifications do not need publishing

📜 Does this require a change to the docs?

The changes in this PR:

  • require changes to docs which are made as part of this PR

🕸️ Does this require a change to the Turbo Graph?

The changes in this PR:

  • do not affect the execution graph

@CiaranMn CiaranMn self-assigned this Jul 27, 2026
@vercel

vercel Bot commented Jul 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hash Ready Ready Preview, Comment Jul 27, 2026 5:17pm
hashdotdesign-tokens Ready Ready Preview, Comment Jul 27, 2026 5:17pm
petrinaut Ready Ready Preview Jul 27, 2026 5:17pm

@cursor

cursor Bot commented Jul 27, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Touches data contract versioning (1.2) and new financial display logic on planning tables; styling/animation changes are localized but user-visible across site overview and slide-overs.

Overview
Adds period material value (quantity through the step × unit cost for the selected time range, independent of outlier filters) to the site planning parameters table and step detail metrics, with sortable Value column and user docs explaining the metric.

Introduces MaterialValueData / computePeriodMaterialValue, wires periodMaterialValue into planning rows, and bumps several supply-chain artifact types to schema 1.2 (including production schedule schema_version split for 1.1 vs 1.2 in Zod).

Fixes PandaCSS regressions by splitting active/inactive styles (explicit inactive classes for segmented controls, docs nav, filter triggers, settings collapse) and refactoring the slide-over so the positioner stays full-viewport while only the panel animates right (with new tests). Minor step-detail tweaks: procurement secondary timing badge copy and removal of the median vs previous period cell from key metrics.

Reviewed by Cursor Bugbot for commit 4b4cc69. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions github-actions Bot added area/apps > hash* Affects HASH (a `hash-*` app) area/apps > hash-api Affects the HASH API (app) area/libs Relates to first-party libraries/crates/packages (area) type/eng > frontend Owned by the @frontend team type/eng > backend Owned by the @backend team area/apps labels Jul 27, 2026

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit e9989a5. Configure here.

@vercel
vercel Bot temporarily deployed to Preview – petrinaut July 27, 2026 16:59 Inactive
@CiaranMn
CiaranMn added this pull request to the merge queue Jul 27, 2026
Merged via the queue into main with commit 602f13f Jul 27, 2026
65 checks passed
@CiaranMn
CiaranMn deleted the cm/value-column-for-parameters branch July 27, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/apps > hash* Affects HASH (a `hash-*` app) area/apps > hash-api Affects the HASH API (app) area/apps area/libs Relates to first-party libraries/crates/packages (area) type/eng > backend Owned by the @backend team type/eng > frontend Owned by the @frontend team

Development

Successfully merging this pull request may close these issues.

2 participants