Change from meta to data where results are delivered on helper#2358
Draft
s3inlc wants to merge 1 commit into
Draft
Change from meta to data where results are delivered on helper#2358s3inlc wants to merge 1 commit into
s3inlc wants to merge 1 commit into
Conversation
s3inlc
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the GetCracksPerDay helper it makes more sense to send the results in 'data' and not in 'meta' according to the api.
Note: tests will fail until we adjust this also on the python-hashtopolis implementation: hashtopolis/python-hashtopolis#9