refactor: use @heroku/sdk for container commands#3831
Draft
erika-wallace wants to merge 2 commits into
Draft
Conversation
Migrates container:pull, container:push, and container:run commands to use
@heroku/sdk instead of direct APIClient calls.
Changes:
- Replace this.heroku.get<Heroku.App>(`/apps/${app}`) with platform.app.info(app)
- Update src/lib/container/helpers.ts to use App type from @heroku/types/3.sdk
- Remove unused @heroku-cli/schema import
Rewrites tests for container:pull, container:push, and container:run to stub the SDK prototype directly rather than intercepting HTTP with nock. Changes: - Replace nock interceptors with HerokuSDK.prototype.platform stubs - Keep sandbox pattern for DockerHelper stubs - All tests passing with SDK-based stubbing
erika-wallace
had a problem deploying
to
AcceptanceTests
July 24, 2026 15:51 — with 
GitHub Actions
Failure
GitHub Actions
Failure
erika-wallace
had a problem deploying
to
AcceptanceTests
July 24, 2026 15:51 — with
GitHub Actions
Failure
GitHub Actions
Failure
erika-wallace
had a problem deploying
to
AcceptanceTests
July 24, 2026 15:51 — with
GitHub Actions
Error
GitHub Actions
Error
erika-wallace
had a problem deploying
to
AcceptanceTests
July 24, 2026 15:51 — with
GitHub Actions
Error
GitHub Actions
Error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the following
containercommands to@heroku/sdk:container:pullcontainer:pushcontainer:runDetails
GET /apps/{app}call withplatform.app.info(app)GET /apps/{app}call withplatform.app.info(app)GET /apps/{app}call withplatform.app.info(app)type Appfrom@heroku/types/3.sdkType of Change
Breaking Changes (major semver update)
!after your change type to denote a change that breaks current behaviorFeature Additions (minor semver update)
Patch Updates (patch semver update)
Testing
Notes:
Steps:
Screenshots (if applicable)
Related Issues
GUS work item: W-23383781