Support organization packages in the outdated diffs link#1205
Merged
Conversation
Carry the lock repository through to build_diff_link/1 so `mix hex.outdated` emits repository-qualified comparisons (ORG/name:from:to) for organization packages and skips packages from custom repositories that hex.pm cannot diff. Repository-qualified links are never shortened, so organization and package names are not exposed through an unauthenticated short-URL redirect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
mix hex.outdatedproduce working diff links for organization packages.Today the repository is dropped when building the
hex.pm/diffslink, so privatepackages get a public-style
name:from:tocomparison that resolves against thewrong package or 404s.
The lock repository is now carried through to
build_diff_link/1, which maps:hexpmtoname:from:to(unchanged)hexpm:ORGtoORG/name:from:to, matching the repo-scoped diff routehost (this also drops today's broken links for custom repositories)
Repository-qualified links are never run through the short-URL service. Short
codes are unauthenticated redirects, so shortening one would expose the
organization and package names in the
Locationheader. The long URL is printedinstead.
Builds on #1204 and pairs with hexpm#1728, which adds the
/diff/:repository/:package/:versionsroute and repository-qualified parsing onthe
/diffsindex.