Skip to content

feat(jobs): add cancellation and queued source transfers - #666

Merged
hmjn023 merged 2 commits into
feat/v2-migration-foundationfrom
feat/v2-migration-backed-jobs
Aug 11, 2026
Merged

feat(jobs): add cancellation and queued source transfers#666
hmjn023 merged 2 commits into
feat/v2-migration-foundationfrom
feat/v2-migration-backed-jobs

Conversation

@hmjn023

@hmjn023 hmjn023 commented Aug 10, 2026

Copy link
Copy Markdown
Owner

Stack created with GitHub Stacks CLIGive Feedback 💬

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)
  • develop

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 42b04fe9-eedd-4cfc-b66e-d5681f792439

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@hmjn023
hmjn023 force-pushed the feat/v2-migration-backed-jobs branch from 253f1ff to 57ff3f7 Compare August 10, 2026 15:22

@hmjn023 hmjn023 left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

追加レビューです。#663 に既にある同一source sync、retryのCAS、jobs output schema、raw error、retry eventの指摘とは重複しない追加リスクをコメントしています。特に stale recovery、parent cancellation、restore lifecycle、通常完了イベントはmerge前に対応が必要です。

Comment thread packages/db/src/repositories/job-repository.ts Outdated
Comment thread apps/server/src/infrastructure/api/routers/jobs-router.ts Outdated
Comment thread apps/server/src/application/services/source-transfer-job-service.ts Outdated
Comment thread apps/server/src/infrastructure/jobs/job-worker.ts
Comment thread apps/server/src/application/services/job-transfer-storage.ts
Comment thread apps/server/src/application/services/directory-sync-service.ts Outdated
Comment thread apps/server/src/infrastructure/api/routers/sources-router.ts
@hmjn023
hmjn023 force-pushed the feat/v2-migration-backed-jobs branch from 57ff3f7 to 7be73cf Compare August 11, 2026 06:42
@hmjn023
hmjn023 force-pushed the feat/v2-migration-backed-jobs branch from 7be73cf to 2f8b821 Compare August 11, 2026 07:41
@hmjn023
hmjn023 merged commit 5df44cf into develop Aug 11, 2026
1 check passed
@hmjn023
hmjn023 deleted the feat/v2-migration-backed-jobs branch August 12, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant