fix: prevent restore timeout for large imports - #673
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughZIPおよびNDJSONのインポートを、同期処理から非同期ジョブ登録へ変更しました。UIはインポート結果ではなく Changesソースインポートのジョブ登録
Estimated code review effort: 3 (Moderate) | ~20 minutes Mergeability Score: ⚪ Minimal · up to Large NDJSON/TAR restores now run through background jobs instead of waiting on the synchronous timeout, while clients report that the job was submitted. No actionable merge-blocking risk remains beyond normal checks and review. Sequence Diagram(s)sequenceDiagram
participant SourceMediaPage
participant sources-api
participant enqueueImport
SourceMediaPage->>sources-api: ZIPまたはNDJSONファイルを渡す
sources-api->>enqueueImport: id、ファイル、モードを渡す
enqueueImport-->>sources-api: JobDtoを返す
sources-api-->>SourceMediaPage: JobDtoを返す
SourceMediaPage-->>SourceMediaPage: ジョブID先頭8文字を通知
Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
概要
大容量のNDJSON/TAR restoreが同期APIの30秒タイムアウトで失敗する問題を修正します。
変更内容
検証
Summary by CodeRabbit