fix(file_format): cover jsonl in addition to json for taskset definitions#486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jsonlformat too, in addition tojsonformatNote
Low Risk
One-line glob change in Harbor export cleanup only; no auth, runtime, or grading behavior changes.
Overview
Harbor export copies the env build context into each task’s
environment/folder and already removes copied HUD taskset definition files so they don’t end up in the image.The cleanup glob is widened from
*.jsonto*.json*, so.jsonltaskset exports (and otherjson-prefixed names) are removed the same way as plain.jsonfiles when the source tasks file lives in that build context.Reviewed by Cursor Bugbot for commit c970f79. Bugbot is set up for automated code reviews on this repo. Configure here.