Enable -cce-vf-aa-between-iters by default for A5 CCEC builds#1446
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughChangesA5 compiler flag configuration
Estimated code review effort: 1 (Trivial) | ~5 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
7e3e6eb to
2ac1b81
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@simpler_setup/toolchain.py`:
- Around line 192-197: Update the platform check in the toolchain flag builder
so it targets only real A5 hardware, removing the ineffective a5sim branch from
CCECToolchain. If a5sim support is required, instead add the option through the
host G++ simulation flag path used when self.ccec is unset; otherwise document
that the setting applies only to A5 hardware.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 40f5e2be-d480-46be-97c4-c201103d41fc
📒 Files selected for processing (1)
simpler_setup/toolchain.py
3081909 to
dd27361
Compare
|
Addressed CodeRabbit feedback: narrowed the flag to A5 hardware only ( |
0cc0b17 to
e8caeb2
Compare
Pin BiSheng inter-iteration VF alias analysis on A5 hardware CCEC so fusion runs under the stricter AA that BiSheng plans to make always-on. Skip a5sim: KernelCompiler leaves ccec unset there and uses Gxx15Toolchain instead.
Summary
-mllvm -cce-vf-aa-between-iters=trueto the default CCEC flags for A5 hardware.KernelCompilerleavesccecunset and usesGxx15Toolchain, so this LLVM option does not apply there.qkv_proj_rope.py(decode,-p a5) fails with VF fusion alone (AICore / scheduler stall); adding this option makes it PASS. Turning fusion off also PASSes.Test plan
CCECToolchain(platform="a5").get_compile_flags()includes-mllvm/-cce-vf-aa-between-iters=trueCCECToolchain(platform="a2a3")and a5sim kernel path do not add this optionqkv_proj_rope.py -p a5 --mode decodePASSes