Skip to content

Get rid of MPI compilation warnings #256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
astrofrog merged 1 commit into from
Jul 22, 2026
+77 −7
Merged

Get rid of MPI compilation warnings #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions Makefile.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,8 @@ OBJECTS_CAR_SER = src/mpi/mpi_core_nompi.f90 \
src/mpi/mpi_routines_nompi.f90 \
$(OBJECTS3)

OBJECTS_CAR_MPI = src/mpi/mpi_core.f90 \
OBJECTS_CAR_MPI = src/mpi/mpi_interfaces.f90 \
src/mpi/mpi_core.f90 \
fortranlib/src/@posix_module_mpi@.f90 \
$(COMMON) \
src/core/core_lib.f90 \
Expand Down Expand Up @@ -95,7 +96,8 @@ OBJECTS_AMR_SER = src/mpi/mpi_core_nompi.f90 \
src/mpi/mpi_routines_nompi.f90 \
$(OBJECTS3)

OBJECTS_AMR_MPI = src/mpi/mpi_core.f90 \
OBJECTS_AMR_MPI = src/mpi/mpi_interfaces.f90 \
src/mpi/mpi_core.f90 \
fortranlib/src/@posix_module_mpi@.f90 \
$(COMMON) \
src/core/core_lib.f90 \
Expand Down Expand Up @@ -129,7 +131,8 @@ OBJECTS_OCT_SER = src/mpi/mpi_core_nompi.f90 \
src/mpi/mpi_routines_nompi.f90 \
$(OBJECTS3)

OBJECTS_OCT_MPI = src/mpi/mpi_core.f90 \
OBJECTS_OCT_MPI = src/mpi/mpi_interfaces.f90 \
src/mpi/mpi_core.f90 \
fortranlib/src/@posix_module_mpi@.f90 \
$(COMMON) \
src/core/core_lib.f90 \
Expand Down Expand Up @@ -164,7 +167,8 @@ OBJECTS_VOR_SER = src/mpi/mpi_core_nompi.f90 \
src/mpi/mpi_routines_nompi.f90 \
$(OBJECTS3)

OBJECTS_VOR_MPI = src/mpi/mpi_core.f90 \
OBJECTS_VOR_MPI = src/mpi/mpi_interfaces.f90 \
src/mpi/mpi_core.f90 \
fortranlib/src/@posix_module_mpi@.f90 \
$(COMMON) \
src/extern/kdtree2/kdtree2.f90 \
Expand Down Expand Up @@ -199,7 +203,8 @@ OBJECTS_SPH_SER = src/mpi/mpi_core_nompi.f90 \
src/mpi/mpi_routines_nompi.f90 \
$(OBJECTS3)

OBJECTS_SPH_MPI = src/mpi/mpi_core.f90 \
OBJECTS_SPH_MPI = src/mpi/mpi_interfaces.f90 \
src/mpi/mpi_core.f90 \
fortranlib/src/@posix_module_mpi@.f90 \
$(COMMON) \
src/core/core_lib.f90 \
Expand Down Expand Up @@ -233,7 +238,8 @@ OBJECTS_CYL_SER = src/mpi/mpi_core_nompi.f90 \
src/mpi/mpi_routines_nompi.f90 \
$(OBJECTS3)

OBJECTS_CYL_MPI = src/mpi/mpi_core.f90 \
OBJECTS_CYL_MPI = src/mpi/mpi_interfaces.f90 \
src/mpi/mpi_core.f90 \
fortranlib/src/@posix_module_mpi@.f90 \
$(COMMON) \
src/core/core_lib.f90 \
Expand Down
61 changes: 61 additions & 0 deletions src/mpi/mpi_interfaces.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
! Explicit interfaces for the MPI routines that take "choice" buffer
! arguments (buffers that can be of any type and rank). The mpich "mpi"
! module does not declare interfaces for these routines, so gfortran 10 and
! later warns about every pair of calls to the same routine with buffers of
! different types or ranks. The NO_ARG_CHECK attribute (supported by both
! gfortran and the Intel compilers, and ignored as a comment by others)
! reproduces the "ignore type, kind and rank" behaviour that MPI
! implementations themselves use for choice buffers, while keeping the
! non-buffer arguments type-checked.

module mpi_interfaces

implicit none

interface

subroutine mpi_bcast(buffer, count, datatype, root, comm, ierror)
!GCC$ ATTRIBUTES NO_ARG_CHECK :: buffer
!DEC$ ATTRIBUTES NO_ARG_CHECK :: buffer
type(*) :: buffer(*)
integer :: count, datatype, root, comm, ierror
end subroutine mpi_bcast

subroutine mpi_reduce(sendbuf, recvbuf, count, datatype, op, root, comm, ierror)
!GCC$ ATTRIBUTES NO_ARG_CHECK :: sendbuf, recvbuf
!DEC$ ATTRIBUTES NO_ARG_CHECK :: sendbuf, recvbuf
type(*) :: sendbuf(*), recvbuf(*)
integer :: count, datatype, op, root, comm, ierror
end subroutine mpi_reduce

subroutine mpi_allreduce(sendbuf, recvbuf, count, datatype, op, comm, ierror)
!GCC$ ATTRIBUTES NO_ARG_CHECK :: sendbuf, recvbuf
!DEC$ ATTRIBUTES NO_ARG_CHECK :: sendbuf, recvbuf
type(*) :: sendbuf(*), recvbuf(*)
integer :: count, datatype, op, comm, ierror
end subroutine mpi_allreduce

subroutine mpi_recv(buf, count, datatype, source, tag, comm, status, ierror)
!GCC$ ATTRIBUTES NO_ARG_CHECK :: buf
!DEC$ ATTRIBUTES NO_ARG_CHECK :: buf
type(*) :: buf(*)
integer :: count, datatype, source, tag, comm, status(*), ierror
end subroutine mpi_recv

subroutine mpi_isend(buf, count, datatype, dest, tag, comm, request, ierror)
!GCC$ ATTRIBUTES NO_ARG_CHECK :: buf
!DEC$ ATTRIBUTES NO_ARG_CHECK :: buf
type(*) :: buf(*)
integer :: count, datatype, dest, tag, comm, request, ierror
end subroutine mpi_isend

subroutine mpi_irecv(buf, count, datatype, source, tag, comm, request, ierror)
!GCC$ ATTRIBUTES NO_ARG_CHECK :: buf
!DEC$ ATTRIBUTES NO_ARG_CHECK :: buf
type(*) :: buf(*)
integer :: count, datatype, source, tag, comm, request, ierror
end subroutine mpi_irecv

end interface

end module mpi_interfaces
3 changes: 2 additions & 1 deletion src/mpi/mpi_io.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
! MD5 of template: d391eca44de1bf600f23e91f9dab6ebf
! MD5 of template: 1e1c708fb2055feec7cad222682bbe09
module mpi_hdf5_io

use core_lib
use mpi
use mpi_interfaces
use mpi_core

implicit none
Expand Down
1 change: 1 addition & 0 deletions src/mpi/mpi_io_template.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ module mpi_hdf5_io

use core_lib
use mpi
use mpi_interfaces
use mpi_core

implicit none
Expand Down
1 change: 1 addition & 0 deletions src/mpi/mpi_routines.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
module mpi_routines

use mpi
use mpi_interfaces
use mpi_core
use core_lib
use grid_physics
Expand Down
Loading