Update to tracing 0.1.36 - #305
Conversation
`tracing 0.1.35` pulls in `tracing-core 0.1.27` which adopted `once_cell` over `lazy_static`, fixing some macro issues I had when I tried to compile with minimal dependencies. `tracing 0.1.36` is explicitly guaranteed to compile with `-Zminimal-versions`. `hyper-util` explicitly does not compile against the minimal version of `tracing 0.1` as it uses misc features added between `0.1 and 0.x`. `0.1.36` is within `hyper-util`'s MSRV bound. This version of `tracing` is sufficient for all my experiments I did with `-Zminimal-versions`, hence why I PR it here, but I can't confirm this is sufficient for all environments, the exact latest version of `hyper-util`, and in the future, a workflow confirming `hyper-util` compiles with `-Zminimal-versions` would be valuable. I also encountered issues with how `tower 0.4` wouldn't compile against `tower-layer 0.3` (solely `tower-layer 0.3.1`), but `tower` is no longer an explicit dependency of `hyper-util`.
https://github.com/tokio-rs/tokio/blob/master/tokio/CHANGELOG.md#1130-october-29-2021 added `watch::Sender::send_replace`, as used in `src/client/legacy/connect/capture.rs`.
|
Do we need to explicitly depend on this version? Unless we're using a new feature, I prefer to specify the oldest version we can, so that consumers can decide the actual version themselves in their lockfile. |
|
I needed The |
|
What I mean is, you can always run |
|
Yes, but if you run with This PR, effectively, corrects |
|
Got it, that's what I was wondering, thanks! |
|
Thanks! One less bother for me. Also, I'm sure it's an obvious comment, but thanks for all your work on HTTP in the Rust ecosystem. I'm much appreciative :) |
tracing 0.1.35pulls intracing-core 0.1.27which adoptedonce_celloverlazy_static, fixing some macro issues I had when I tried to compile with minimal dependencies.tracing 0.1.36is explicitly guaranteed to compile with-Zminimal-versions.hyper-utilexplicitly does not compile against the minimal version oftracing 0.1as it uses misc features added between0.1 and 0.x.0.1.36is withinhyper-util's MSRV bound.This version of
tracingis sufficient for all my experiments I did with-Zminimal-versions, hence why I PR it here, but I can't confirm this is sufficient for all environments, the exact latest version ofhyper-util, and in the future, a workflow confirminghyper-utilcompiles with-Zminimal-versionswould be valuable. I also encountered issues with howtower 0.4wouldn't compile againsttower-layer 0.3(solelytower-layer 0.3.1), buttoweris no longer an explicit dependency ofhyper-util.