docs(readme): mark scikit-learn→MLJ as planned, not shipped (G38)#49
Merged
Merged
Conversation
…d (G38) The "Supported Patterns" table claimed `scikit-learn pipelines → MLJ.jl` as a translated pattern, but the codegen implements no sklearn→MLJ conversions: the `sk` alias is DETECTED in src/codegen/parser.rs, yet src/codegen/julia_gen.rs has zero sklearn/MLJ mappings. Marked the row ⚠ Planned to match reality. Ground-truthed the rest of the table against src/codegen/julia_gen.rs — every other row is genuinely implemented (pandas, numpy, scipy.optimize/integrate, matplotlib→Plots, R data.frame via dplyr/tidyr/stats), so only the sklearn row was an overclaim.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
G38 — the README "Supported Patterns" table claimed
scikit-learn pipelines → MLJ.jlas a translated pattern, but the codegen implements no sklearn→MLJ conversions. Marked that one row as ⚠ Planned to match reality.Changes
README.md: thescikit-learnrow now reads ⚠ Planned — imports are detected (skalias insrc/codegen/parser.rs) but no sklearn→MLJ function conversions are mapped insrc/codegen/julia_gen.rs.RSR Quality Checklist
Required
As Applicable
Testing
Ground-truthed the whole table against
src/codegen/julia_gen.rs:pandas(15 maps),numpy(17),scipy(optimize→Optim, integrate→QuadGK),matplotlib.pyplot→Plots (plot/scatter/hist/…), Rdata.frameviadplyr(10)/tidyr(4)/stats(5)/readr(2).scikit-learn→MLJ — zero maps in the codegen; only the alias is detected.So only the sklearn row was inaccurate.
Noted for follow-up (not in this PR): G37 (unrendered
{{PROJECT_NAME}}/{{project}}/{{AUTHOR}}template placeholders in Containerfile/guix.scm/.github community docs — mostly comment/header cruft), G34 (.idrnever typechecked — needs anidris2 --buildCI job), G36 (7 emptysrc/subdirs + emptyverification/scaffolding vsphase-1-completeSTATE), G39 (cargo install+ SPDX on.rs/.zig— licence-touchy, owner-gated like Axiom G17). The README itself is.mdwhere the estate default is.adoc(format drift, separate from this content fix).🤖 Generated with Claude Code
Generated by Claude Code