IBX-11237: websiteId section added#3281
Merged
Merged
Conversation
Preview of modified filesPreview of modified Markdown: |
Summary
Errors per inputErrors in site/templating/twig_function_reference/recommendations_twig_functions/index.html
|
tbialcz
approved these changes
Jul 8, 2026
mnocon
reviewed
Jul 10, 2026
mnocon
left a comment
Contributor
There was a problem hiding this comment.
This is a confusing concept, and to make it clearer we need to provide better description of the use cases where the custom id should be provided.
The example with websiteId: 'ibexa_user_get_current().login' is not enough for two reasons:
- it does not handle the anonymous user, for which the website id should not be set (at least that's how I understand this)
- it's not clear whether it's recommended and better than the default behaviour - because by default, user id is sent as website id:
https://github.com/ibexa/connector-raptor/blob/1b622a028435145e513dc14b6cee8dd14bd076a4/src/lib/Tracking/ContextProvider/LoggedInUserWebsiteIdContextProvider.php#L20-L25 , based on user remote identifier:
The use cases I'm thinking of where providing a custom website id might be needed:
- custom CRM scenario - if you store information about your customers in an external CRM system, you might use one of the identifiers stored there and send that instead of the default value
- B2B scenario - send company identifier (the company the user belongs to) instead of an ID of a single user to track actions of the whole company, not a single user
mnocon
reviewed
Jul 13, 2026
mnocon
left a comment
Contributor
There was a problem hiding this comment.
Looks good, just some small things to fix - formatting and applying Rector suggestion being the most important
9159b34 to
37b0091
Compare
julitafalcondusza
added a commit
that referenced
this pull request
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist