Stop grapheme_strrev from using UBRK_DONE as a byte index - #234
Closed
iliaal wants to merge 1 commit into
Closed
Conversation
ubrk_previous() returns UBRK_DONE after the first boundary. The loop condition ran before that assignment, so the body treated -1 as an offset and wrote into the zend_string NUL. Break when the iterator is done, and NUL-terminate the result of zend_string_alloc.
Owner
Author
|
Promoted: php#23323 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
grapheme_strrev() called ubrk_previous() inside a loop whose condition still saw the previous position, so UBRK_DONE (-1) was used as a byte offset and overwrote the result NUL. Stop when the iterator is done, and NUL-terminate the zend_string_alloc() buffer.