transpile: Refactor binary operand handling and handle pointers/complex numbers - #1835
Open
Rua wants to merge 3 commits into
Open
transpile: Refactor binary operand handling and handle pointers/complex numbers#1835Rua wants to merge 3 commits into
Rua wants to merge 3 commits into
Conversation
Rua
force-pushed
the
expected_operand_types
branch
3 times, most recently
from
June 2, 2026 13:59
b78f827 to
d93cde7
Compare
Rua
force-pushed
the
expected_operand_types
branch
3 times, most recently
from
June 13, 2026 15:43
854e317 to
7efb825
Compare
Rua
changed the title
CBinOp::expected_operand_types and handle pointers/complex numbers
Rua
force-pushed
the
expected_operand_types
branch
5 times, most recently
from
June 19, 2026 10:32
e62b79c to
85e05aa
Compare
Rua
force-pushed
the
expected_operand_types
branch
3 times, most recently
from
July 7, 2026 10:21
d79be12 to
fa2af73
Compare
ahomescu
requested changes
Jul 17, 2026
ahomescu
left a comment
ahomescu
left a comment
Contributor
There was a problem hiding this comment.
Could you add a test or two for this (unit and/or snapshot)?
Contributor
Author
|
Not really sure what to test for, that isn't already tested? |
Rua
force-pushed
the
expected_operand_types
branch
3 times, most recently
from
July 26, 2026 09:37
a7f8253 to
46b0ce9
Compare
Rua
force-pushed
the
expected_operand_types
branch
from
July 26, 2026 10:18
46b0ce9 to
31c8fbb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both a refactor and a functional improvement. Complex numbers aren't supported yet, so I haven't included any tests for that, but this is needed to support them later.