transpile: Emit integer literal suffixes where possible#1920
Open
Rua wants to merge 1 commit into
Open
Conversation
ahomescu
reviewed
Jul 23, 2026
|
|
||
| let lit_str = if let Some(suffix) = suffix { | ||
| match base { | ||
| IntBase::Dec => format!("{val}_{suffix}"), |
Contributor
There was a problem hiding this comment.
@randomPoison @fw-immunant @thedataking Do we have a preference here between with and without the underscore? I'm slightly against it.
Contributor
Author
There was a problem hiding this comment.
I find the underscores a little clearer, but it doesn't matter to me that much.
Contributor
There was a problem hiding this comment.
I'm slightly in favor of underscore, but seems like a pretty inconsequential detail.
Contributor
There was a problem hiding this comment.
An anti-underscore vote here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A minor style improvement to the produced code.