refactor: fix macros misclassified in the type namespace - #1931
Open
ahomescu wants to merge 2 commits into
Open
refactor: fix macros misclassified in the type namespace #1931ahomescu wants to merge 2 commits into
ahomescu wants to merge 2 commits into
Conversation
ahomescu
force-pushed
the
ahomescu/fix_reorganize_definitions/macro_ns
branch
from
July 25, 2026 01:40
cb5a21c to
bfe429f
Compare
ahomescu
force-pushed
the
ahomescu/fix_reorganize_definitions/macro_ns
branch
from
July 25, 2026 01:57
bfe429f to
82393af
Compare
ahomescu
force-pushed
the
ahomescu/fix_reorganize_definitions/macro_ns
branch
from
July 25, 2026 02:07
82393af to
b56cca7
Compare
ahomescu
changed the base branch from
ahomescu/fix_reorganize_definitions/deterministic_externs
to
ahomescu/fix_reorganize_definitions/deterministic_orphaned_impls
July 25, 2026 02:11
ahomescu
force-pushed
the
ahomescu/fix_reorganize_definitions/macro_ns
branch
from
July 25, 2026 02:11
b56cca7 to
03b1b5e
Compare
ahomescu
force-pushed
the
ahomescu/fix_reorganize_definitions/macro_ns
branch
2 times, most recently
from
July 25, 2026 02:44
74522f7 to
2686099
Compare
ahomescu
force-pushed
the
ahomescu/fix_reorganize_definitions/macro_ns
branch
from
July 25, 2026 03:17
2686099 to
9ca01d8
Compare
ahomescu
force-pushed
the
ahomescu/fix_reorganize_definitions/macro_ns
branch
from
July 25, 2026 03:26
9ca01d8 to
ed80965
Compare
ahomescu
force-pushed
the
ahomescu/fix_reorganize_definitions/macro_ns
branch
from
July 25, 2026 05:09
ed80965 to
d740d9d
Compare
ahomescu
force-pushed
the
ahomescu/fix_reorganize_definitions/macro_ns
branch
from
July 25, 2026 05:33
d740d9d to
13b153d
Compare
ahomescu
force-pushed
the
ahomescu/fix_reorganize_definitions/macro_ns
branch
from
July 25, 2026 05:41
13b153d to
e0c42b7
Compare
ahomescu
force-pushed
the
ahomescu/fix_reorganize_definitions/macro_ns
branch
from
July 25, 2026 05:42
e0c42b7 to
3c180fd
Compare
ahomescu
force-pushed
the
ahomescu/fix_reorganize_definitions/macro_ns
branch
2 times, most recently
from
July 25, 2026 05:52
3f0fdd2 to
2078086
Compare
ahomescu
changed the base branch from
ahomescu/fix_reorganize_definitions/deterministic_orphaned_impls
to
ahomescu/fix_reorganize_definitions/extern_abi_fallback
July 25, 2026 05:52
ahomescu
force-pushed
the
ahomescu/fix_reorganize_definitions/macro_ns
branch
from
July 25, 2026 05:59
2078086 to
5d88152
Compare
ahomescu
force-pushed
the
ahomescu/fix_reorganize_definitions/macro_ns
branch
2 times, most recently
from
July 25, 2026 06:16
660b5ba to
87eed92
Compare
ahomescu
force-pushed
the
ahomescu/fix_reorganize_definitions/macro_ns
branch
2 times, most recently
from
July 25, 2026 06:43
7cd06f1 to
aba174b
Compare
ahomescu
force-pushed
the
ahomescu/fix_reorganize_definitions/macro_ns
branch
from
July 25, 2026 06:51
aba174b to
61988a4
Compare
ahomescu
force-pushed
the
ahomescu/fix_reorganize_definitions/macro_ns
branch
2 times, most recently
from
July 30, 2026 00:19
cdb6dd9 to
6111873
Compare
ahomescu
force-pushed
the
ahomescu/fix_reorganize_definitions/macro_ns
branch
from
July 30, 2026 00:31
6111873 to
370e026
Compare
ahomescu
force-pushed
the
ahomescu/fix_reorganize_definitions/macro_ns
branch
2 times, most recently
from
July 30, 2026 22:56
45308cb to
756a0da
Compare
`_ => Namespace::TypeNS` arm lumps `MacroDef` (MacroNS) into TypeNS. Harmless for transpiled C, but wrong in general.
ahomescu
force-pushed
the
ahomescu/fix_reorganize_definitions/macro_ns
branch
from
July 30, 2026 22:58
756a0da to
a6c129e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack created with GitHub Stacks CLI • Give Feedback 💬